Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route to clear cache #247

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Add route to clear cache #247

merged 2 commits into from
Oct 31, 2017

Conversation

lyoshenka
Copy link
Member

Going to /clear-cache will clear the APC cache

@lyoshenka lyoshenka self-assigned this Oct 31, 2017
@lyoshenka lyoshenka requested a review from kauffj October 31, 2017 11:56
@kauffj
Copy link
Member

kauffj commented Oct 31, 2017

@lyoshenka two potential changes:

  • Is it an issue that anyone can clear the APC cache? Especially since this is an open-source project...
  • Can the post-commit hook that updates the website hit this on every deploy?

kauffj
kauffj requested changes Oct 31, 2017
View reviewed changes
Copy link
Member

@kauffj kauffj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(comments left above)

@lyoshenka
Copy link
Member Author

  1. not worried about that, but its easy to lock down if you want
  2. done

@kauffj kauffj merged commit e9df217 into master Oct 31, 2017
@lyoshenka lyoshenka deleted the clear-cache branch November 1, 2017 13:25
@lyoshenka lyoshenka mentioned this pull request Nov 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kauffj kauffj kauffj requested changes

Assignees

@lyoshenka lyoshenka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lyoshenka @kauffj