Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the Password Manager issue #69

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fixing the Password Manager issue #69

merged 1 commit into from
Apr 1, 2021

Conversation

iMonZ
Copy link
Contributor

@iMonZ iMonZ commented Mar 25, 2021

Fixing the Password Manager issue from: #68 and #26

Theoretically this should work, but I get this error while testing: "Cannot show Automatic Strong Passwords for app bundleID...due to error: Cannot save passwords for this app. Make sure you have set up Associated Domains for your app and AutoFill Passwords is enabled in Settings"

This could be a certificate error maybe someone with access to the odysee certificate can try that out. (The Domain of the odysee Website should be verified inside the Apple account which is not the case in my testing account.)

@lyoshenka
Copy link

@iMonZ thanks for this PR. we'll take a look at it soon

Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@lbry-bot lbry-bot assigned lyoshenka and unassigned akinwale Apr 1, 2021
@akinwale akinwale marked this pull request as ready for review April 1, 2021 15:38
@akinwale akinwale merged commit 41620d3 into OdyseeTeam:master Apr 1, 2021
@iMonZ iMonZ deleted the passwordManager branch April 1, 2021 15:38
@tzarebczan
Copy link
Contributor

tzarebczan commented Apr 1, 2021

Thanks so much for the contribution! Can we show you some appreciation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants