Add support to validate against multiple keys #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
force-pushed
the
add-support-to-validate-against-multiple-keys
branch
from
4b96fe0
to
a6afecf
Compare
lcobucci
commented
Nov 4, 2023
lcobucci
force-pushed
the
add-support-to-validate-against-multiple-keys
branch
from
a6afecf
to
7914f55
Compare
Slamdunk
requested changes
Nov 6, 2023
lcobucci
force-pushed
the
add-support-to-validate-against-multiple-keys
branch
from
7914f55
to
26960f1
Compare
Slamdunk
approved these changes
Nov 20, 2023
This allows us to stop using PHPUnit mocks in every place that needs, making tests more obvious. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
When dealing with key rotations, we will likely have to verify previously issued tokens (signed with the old key) and new tokens (signed with the new key). This introduces a handy constraint that can take multiple `SignedWith` constraints and only raise exceptions when the signature can't be validated by any of them. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
add-support-to-validate-against-multiple-keys
branch
from
26960f1
to
4a98f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the design I suggested on #1011 (comment) to solve the limitation raised by @rhertogh