Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SodiumBase64Polyfill fallback method reference #685

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Fix SodiumBase64Polyfill fallback method reference #685

merged 1 commit into from
Feb 19, 2021

Conversation

Slamdunk
Copy link
Collaborator

Supersedes #684

@lcobucci lcobucci added the Bug label Feb 19, 2021
@lcobucci lcobucci added this to the 4.1.2 milestone Feb 19, 2021
lcobucci
lcobucci approved these changes Feb 19, 2021
View reviewed changes
Copy link
Owner

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! How did I miss this on the review 😭

@lcobucci lcobucci merged commit c544710 into 4.1.x Feb 19, 2021
@lcobucci lcobucci deleted the Slamdunk-patch-1 branch February 19, 2021 19:37
@lcobucci lcobucci self-assigned this Feb 19, 2021
@lcobucci lcobucci changed the title SodiumBase64Polyfill: fix fallback method reference Fix SodiumBase64Polyfill fallback method reference Feb 19, 2021
@github-actions github-actions bot mentioned this pull request Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcobucci lcobucci lcobucci approved these changes

Assignees

@lcobucci lcobucci

Labels
Bug
Projects
None yet
Milestone
4.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Slamdunk @lcobucci