-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clear that you performed an action without having to refresh #1
Comments
The part of having to reload to view the updated data had to do with the fact that loadReservations() is a reactive function. I made a non-reactive function loadReservationsFunc() [with the original code of loadReservations()] so that I could force the app to re-load the data when needed. The reactivity overview tutorial helped me with this http://rstudio.github.io/shiny/tutorial/#reactivity-overview. For making clear that you performed an action, I modified the checkEntry() code and added an observer() to change the options for the "action" input. My reply was:
|
…servations Basically, prior to this version, if a student selected a slot with a TA (say TA #1) and the student selected the "submit reservation" option as the action to perform, all of this while the slot they were interested in was already taken, then no reservation would be made. But the final option selection would still be "submit reservation". So if the student, then switched TAs (without changing the day of the week) to another TA (say TA # 2), it would then submit the reservation without checking if TA # 2 had a valid slot that day. Now with version v0.0.16, if the student tries to make an invalid reservation, the action to perform selector would be reset. So when the student switched TAs, no reservations would be automatically created. The student would have to select the "submit reservation" option a second time, and if the check did not pass the reservation would not be made.
Received the following suggestion:
The text was updated successfully, but these errors were encountered: