Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear that you performed an action without having to refresh #1

Closed
lcolladotor opened this issue Jan 28, 2014 · 1 comment
Closed

Comments

@lcolladotor
Copy link
Owner

Received the following suggestion:

One small suggestion -- at the end of the form, you pick either submit or cancel, but I didn't see a clear "submit" "cancel" or "send form" button -- you just have to refresh the page, right?  Totally functional, but students might appreciate the peace of mind that it went...not sure if that's a big deal to add or not...just a thought.
@lcolladotor
Copy link
Owner Author

The part of having to reload to view the updated data had to do with the fact that loadReservations() is a reactive function. I made a non-reactive function loadReservationsFunc() [with the original code of loadReservations()] so that I could force the app to re-load the data when needed. The reactivity overview tutorial helped me with this http://rstudio.github.io/shiny/tutorial/#reactivity-overview.

For making clear that you performed an action, I modified the checkEntry() code and added an observer() to change the options for the "action" input.

My reply was:

I think that I managed to implement what you were suggesting (with drop down menus instead of buttons). Now, once you either cancel or reserve, the menu changes to reflect this. Also, you no longer need to reload to see the updated information. You now only strictly need to reload if you wish to perform another action (which should be very rare).

lcolladotor added a commit that referenced this issue Apr 6, 2016
…servations

Basically, prior to this version, if a student selected a slot with a TA (say
TA #1) and the student selected the "submit reservation" option as the action to
perform, all of this while the slot they were interested in was already taken,
then no reservation would be made. But the final option selection would still
be "submit reservation". So if the student, then switched TAs (without changing
the day of the week) to another TA (say TA # 2), it would then submit the
reservation without checking if TA # 2 had a valid slot that day.

Now with version v0.0.16, if the student tries to make an invalid reservation,
the action to perform selector would be reset. So when the student switched TAs,
no reservations would be automatically created. The student would have to select
the "submit reservation" option a second time, and if the check did not pass
the reservation would not be made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant