Correct file path management #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Precheck on 1944998 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
loganharbour
force-pushed
the
moose_26947
branch
from
1944998
to
451c24f
Compare
cticenhour
requested changes
Mar 20, 2024
loganharbour
force-pushed
the
moose_26947
branch
2 times, most recently
from
ca1cc7d
to
3960547
Compare
This was referenced Mar 21, 2024
|
@cticenhour this is ready for review. Zapdos passes all tests with shannon-lab/zapdos#240. |
loganharbour
force-pushed
the
moose_26947
branch
from
3960547
to
a26869d
Compare
cticenhour
requested changes
Mar 21, 2024
|
Test results: https://civet.inl.gov/pr/21435/ |
cticenhour
approved these changes
Mar 22, 2024
Co-authored-by: Casey Icenhour <cticenhour@gmail.com>
Co-authored-by: Casey Icenhour <cticenhour@gmail.com>
loganharbour
force-pushed
the
moose_26947
branch
from
6511121
to
8ecb734
Compare
cticenhour
approved these changes
Mar 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs idaholab/moose#26947
Requires idaholab/moose#27143 and is in support of idaholab/moose#26947
All
file_locationparameters are set to theFileNametype, which eventually will be auto filled with the correct absolute path to the file base. For objects that have a default, the default is set to.(cwd of the input file). Allproperty_fileparameters are set to theRelativeFileNametype, which means don't have their absolute paths resolved so you can do<file_location>/<property_file>.