Improve `MooseObject::mooseError()` with more context, correct file paths with many inputs #26945

loganharbour · 2024-03-02T00:25:43Z

Closes #26947

For objects created within a non-MooseObjectAction, their moose errors are associated with the syntax location for the associated action
For objects created in any action whose parameters are applied with applyParameters() from the action's parameters, paramError() within said objects will be linked directly to the action's parameters
All objects are forced to be created within the Factory or ActionFactory
Uses the hit node context to figure out absolute paths for all files

App patches:

SAM https://git-nse.egs.anl.gov/SAM/SAM/-/merge_requests/900
Griffin https://github.inl.gov/ncrc/griffin/pull/1827
Pronghorn nonbreaking https://github.inl.gov/ncrc/pronghorn/pull/1257 (good after Prep for MooseObject error improvements #27136 but pronghorn devel is broken)
Bison nonbreaking https://github.inl.gov/ncrc/bison/pull/5900 (good after Prep for MooseObject error improvements #27136)
Zapdos Use new definition for file_location shannon-lab/zapdos#240
Crane Correct file path management lcpp-org/crane#125

moosebuild · 2024-03-02T02:27:22Z

Job Documentation on e662172 wanted to post the following:

View the site here

This comment will be updated on new commits.

framework/include/utils/InputParameters.h

dschwen

Otherwise looks fine

loganharbour · 2024-03-03T18:43:02Z

Good again. Changes: resolved your request, added 5e9aad1. This lets you associate actions that you create in a meta action with a parameter. Easiest example is Outputs/exodus=true associates errors in the created Exodus object with Outputs/exodus=true.

moosebuild · 2024-03-03T19:57:36Z

Job Test timings on e662172 wanted to post the following:

View timings here

This comment will be updated on new commits.

moosebuild · 2024-03-03T21:10:10Z

Job Coverage on e662172 wanted to post the following:

Framework coverage

	354ce6	#26945 e66217
	Total	Total	+/-	New
Rate	85.31%	85.31%	+0.00%	88.36%
Hits	101277	101406	+129	372
Misses	17439	17455	+16	49

Diff coverage report

Full coverage report

Modules coverage

External petsc solver

	354ce6	#26945 e66217
	Total	Total	+/-	New
Rate	85.37%	85.37%	-	0.00%
Hits	350	350	-	0
Misses	60	60	-	1

Diff coverage report

Full coverage report

Optimization

	354ce6	#26945 e66217
	Total	Total	+/-	New
Rate	89.16%	89.17%	+0.01%	100.00%
Hits	1957	1959	+2	2
Misses	238	238	-	0

Diff coverage report

Full coverage report

Peridynamics

	354ce6	#26945 e66217
	Total	Total	+/-	New
Rate	77.46%	77.46%	-	100.00%
Hits	3068	3068	-	1
Misses	893	893	-	0

Diff coverage report

Full coverage report

Solid mechanics

	354ce6	#26945 e66217
	Total	Total	+/-	New
Rate	84.78%	84.78%	-0.00%	100.00%
Hits	27113	27109	-4	2
Misses	4868	4868	-	0

Diff coverage report

Full coverage report

Stochastic tools

	354ce6	#26945 e66217
	Total	Total	+/-	New
Rate	90.62%	90.62%	+0.00%	100.00%
Hits	7911	7915	+4	3
Misses	819	819	-	0

Diff coverage report

Full coverage report

Thermal hydraulics

	354ce6	#26945 e66217
	Total	Total	+/-	New
Rate	89.13%	89.11%	-0.02%	75.00%
Hits	13972	13970	-2	3
Misses	1704	1708	+4	1

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

framework new line coverage rate 88.36% is less than the suggested 90.0%
external_petsc_solver new line coverage rate 0.00% is less than the suggested 90.0%
thermal_hydraulics new line coverage rate 75.00% is less than the suggested 90.0%

This comment will be updated on new commits.

lindsayad

Jk, should resolve app errors

loganharbour · 2024-03-05T19:19:59Z

Reminder for self: Still need to resolve file name parameters

lindsayad · 2024-03-06T00:54:10Z

What is the confusion? It is possible that I am the confused one. Do we expect the changes here to incur app failures, and the plan is to patch them?

loganharbour · 2024-03-06T01:25:20Z

The path base where to look for FileName params (files) is not working with this. Working on fixing those rules.

loganharbour · 2024-03-19T18:46:45Z

Excuse all of the spam, I didn't plan on this needing this much more... but it is actually ready for review. few app failures, working on those fixes.

…possible

permcody

I don't see anything concerning here. The only thing I didn't understand as a whole is the "clone" versus "copyConstruct" calls I see. It appears we are using both. What's the difference?

loganharbour · 2024-03-22T01:56:09Z

I don't see anything concerning here. The only thing I didn't understand as a whole is the "clone" versus "copyConstruct" calls I see. It appears we are using both. What's the difference?

Clone duplicates the input parameters and creates a new object from those parameters (less chance at screwing up state). Copy construct is really only used in two cases: direct copy construct for mesh and relationship managers

App failures addressed

loganharbour force-pushed the disallow_characters branch from 1519080 to 16b4d43 Compare March 2, 2024 21:11

loganharbour changed the title ~~Associate parameters with hit nodes as much as possible and use those nodes in errors~~ Improve MooseObject::mooseError() with more context Mar 2, 2024

loganharbour marked this pull request as ready for review March 2, 2024 21:15

loganharbour requested review from lindsayad and roystgnr as code owners March 2, 2024 21:15

loganharbour requested a review from dschwen March 2, 2024 21:15

loganharbour self-assigned this Mar 2, 2024

loganharbour added the PR: Ready for review/merge label Mar 2, 2024

dschwen reviewed Mar 3, 2024

View reviewed changes

framework/include/utils/InputParameters.h Outdated Show resolved Hide resolved

dschwen approved these changes Mar 3, 2024

View reviewed changes

loganharbour requested review from joshuahansel, zachmprince and grmnptr as code owners March 3, 2024 18:36

loganharbour requested a review from dschwen March 3, 2024 18:43

lindsayad approved these changes Mar 5, 2024

View reviewed changes

lindsayad previously requested changes Mar 5, 2024

View reviewed changes

loganharbour changed the title ~~Improve MooseObject::mooseError() with more context~~ Improve MooseObject::mooseError() with more context, correct file paths with many inputs Mar 16, 2024

loganharbour requested a review from GiudGiud as a code owner March 18, 2024 20:14

loganharbour force-pushed the disallow_characters branch 2 times, most recently from e6b2940 to 0423b82 Compare March 19, 2024 22:17

This was referenced Mar 20, 2024

Prep for MooseObject error improvements #27136

Merged

Add relative file name type #27143

Merged

loganharbour added 19 commits March 20, 2024 08:07

Fix up cases where we didn't build with the factory

99700a3

Force all object construction to use factories

98e92e1

More work on getting everything to be constructed with the factories

7012497

Allow copy elision

8241cab

Remove unused include

7594241

Fix OversampleOutput FileMesh creation

8d63b78

Support nested create calls in the factories

37cfe8b

Get NearestPointBase working with threads

693586b

Only check for registered objects

25c59cb

Get unit tests working

5c84d9d

Allow relative, non-data paths in DataFileInterface

9822777

Use MooseBase instead for param errors for objects

e22db81

Use MooseBase in MooseApp

3e7de7f

Correct for absolute paths in unit test

95bbd22

Add comment on absolute paths

7f4fcd0

Move all file path resolution to hit nodes, add more hit nodes where …

b773c6a

…possible

Default to cwd if no hit node is found

cedb11b

Use old method name as to not break things

ef07d11

Remove unused method

cf41d0e

loganharbour force-pushed the disallow_characters branch from 0423b82 to cf41d0e Compare March 20, 2024 14:55

loganharbour added 2 commits March 20, 2024 09:00

Switch to DataFileName

0ad43a2

Add unit tests for file path params

e662172

loganharbour mentioned this pull request Mar 21, 2024

Changes required for file path cleanup in crane shannon-lab/zapdos#239

Closed

permcody approved these changes Mar 21, 2024

View reviewed changes

loganharbour merged commit 091245d into idaholab:next Mar 23, 2024
100 of 103 checks passed

loganharbour deleted the disallow_characters branch March 23, 2024 20:34

loganharbour mentioned this pull request Mar 25, 2024

Create error that represents a known defect #27170

Closed

loganharbour mentioned this pull request Apr 16, 2024

Add a warning for ignored execute_on parameter #27145

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve `MooseObject::mooseError()` with more context, correct file paths with many inputs #26945

Improve `MooseObject::mooseError()` with more context, correct file paths with many inputs #26945

loganharbour commented Mar 2, 2024 •

edited

Loading

moosebuild commented Mar 2, 2024 •

edited

Loading

dschwen left a comment

loganharbour commented Mar 3, 2024

moosebuild commented Mar 3, 2024 •

edited

Loading

moosebuild commented Mar 3, 2024 •

edited

Loading

lindsayad left a comment

loganharbour commented Mar 5, 2024

lindsayad commented Mar 6, 2024

loganharbour commented Mar 6, 2024

loganharbour commented Mar 19, 2024

permcody left a comment

loganharbour commented Mar 22, 2024

Improve MooseObject::mooseError() with more context, correct file paths with many inputs #26945

Improve MooseObject::mooseError() with more context, correct file paths with many inputs #26945

Conversation

loganharbour commented Mar 2, 2024 • edited Loading

moosebuild commented Mar 2, 2024 • edited Loading

dschwen left a comment

Choose a reason for hiding this comment

loganharbour commented Mar 3, 2024

moosebuild commented Mar 3, 2024 • edited Loading

moosebuild commented Mar 3, 2024 • edited Loading

Framework coverage

Modules coverage

External petsc solver

Optimization

Peridynamics

Solid mechanics

Stochastic tools

Thermal hydraulics

Full coverage reports

Warnings

lindsayad left a comment

Choose a reason for hiding this comment

loganharbour commented Mar 5, 2024

lindsayad commented Mar 6, 2024

loganharbour commented Mar 6, 2024

loganharbour commented Mar 19, 2024

permcody left a comment

Choose a reason for hiding this comment

loganharbour commented Mar 22, 2024

Improve `MooseObject::mooseError()` with more context, correct file paths with many inputs #26945

Improve `MooseObject::mooseError()` with more context, correct file paths with many inputs #26945

loganharbour commented Mar 2, 2024 •

edited

Loading

moosebuild commented Mar 2, 2024 •

edited

Loading

moosebuild commented Mar 3, 2024 •

edited

Loading

moosebuild commented Mar 3, 2024 •

edited

Loading