Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to explicitly disable a http_proxy #121

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

janLo
Copy link

@janLo janLo commented Jul 1, 2019

The current code always sets the http proxy from the http_proxy variable
in the current environment. This makes testing difficult in setups where
testlink runs locally but the internet is only available via a proxy.

This allows the user to explicitly set proxy=False in the TestLinkHelper
instantiation.

The current code always sets the http proxy from the http_proxy variable
in the current environment. This makes testing difficult in setups where
testlink runs locally but the internet is only available via a proxy.

This allows the user to explicitly set proxy=False in the TestLinkHelper
instantiation.
@lczub
Copy link
Owner

lczub commented Jul 1, 2019 via email

@lczub
Copy link
Owner

lczub commented Jul 14, 2019

Hello Jan,

I added a test test_connect_ignoring_proxy_env in c92903c. Does it covers your requirement?

Regards Luiko

@lczub lczub merged commit 36b5c07 into lczub:master Aug 10, 2019
@lczub lczub added this to the v0.8.1 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants