Skip to content

Commit

Permalink
Don't exclude functions in object.d from cross-module inlining
Browse files Browse the repository at this point in the history
Resolves #1604. I had no issues compiling druntime and Phobos with
`-DD_FLAGS_RELEASE='-O3;-release;-enable-cross-module-inlining'`.
  • Loading branch information
kinke committed Mar 6, 2019
1 parent 6c3e29e commit 40a82cd
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions gen/function-inlining.cpp
Expand Up @@ -129,15 +129,6 @@ bool defineAsExternallyAvailable(FuncDeclaration &fdecl) {
return false;
}

// TODO: Fix inlining functions from object.d. Currently errors because of
// TypeInfo type-mismatch issue (TypeInfo classes get special treatment by the
// compiler). To start working on it: comment-out this check and druntime will
// fail to compile.
if (fdecl.getModule()->ident == Id::object) {
IF_LOG Logger::println("Inlining of object.d functions is disabled");
return false;
}

if (fdecl.semanticRun >= PASSsemantic3) {
// If semantic analysis has come this far, the function will be defined
// elsewhere and should not get the available_externally attribute from
Expand Down

0 comments on commit 40a82cd

Please sign in to comment.