Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win64: no error status when creating a library fails #1161

Closed
rainers opened this issue Oct 17, 2015 · 1 comment
Closed

Win64: no error status when creating a library fails #1161

rainers opened this issue Oct 17, 2015 · 1 comment

Comments

@rainers
Copy link
Contributor

rainers commented Oct 17, 2015

Here's a repro:

C:\tmp\d\ldc>ldc2 -lib test.d
C:\tmp\d\ldc>attrib +R test.lib
C:\tmp\d\ldc>ldc2 -lib test.d
LINK : fatal error LNK1104: cannot open file 'test.lib'
Error: C:\l\vs14\VC\BIN\lib.exe failed with status: 1104

C:\tmp\d\ldc>echo %ERRORLEVEL%
0

ldc sould return an error here, probably the status of the failing lib call.

rainers added a commit to rainers/ldc that referenced this issue Oct 17, 2015
kinke added a commit that referenced this issue Oct 17, 2015
issue #1161: return status if lib invocation failed
@dnadlinger
Copy link
Member

Fixed by #1162, thanks!

(By the way, if you include something to the effect of closes #<issue_id> or fixes #<issue_id> in the commit message, the PR will be linked with the issue automatically.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants