Mark most GEPs inbounds and add additional param attributes
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -531,7 +531,7 @@ bool DtoLowerMagicIntrinsic(IRState *p, FuncDeclaration *fndecl, CallExp *e, | |||
| assert(bitmask == 31 || bitmask == 63); | |||
| // auto q = cast(size_t*)ptr + (bitnum >> (64bit ? 6 : 5)); | |||
| LLValue *q = DtoBitCast(ptr, DtoSize_t()->getPointerTo()); | |||
| q = DtoGEP1(q, p->ir->CreateLShr(bitnum, bitmask == 63 ? 6 : 5), "bitop.q"); | |||
| q = DtoGEP1(q, p->ir->CreateLShr(bitnum, bitmask == 63 ? 6 : 5), true, "bitop.q"); | |||
There was a problem hiding this comment.
Not sure about this being a legal inbounds.
There was a problem hiding this comment.
The intended semantics for the intrinsics are not really defined in any detail in the upstream docs, but I guess it should be fine.
|
The 2nd commit adds |
| } else if (!passPointer) { | ||
| } else if (passPointer) { | ||
| // ref/out | ||
| attrs.addDereferenceable(loweredDType->size()); |
There was a problem hiding this comment.
getTypeAllocSize(DtoType(loweredDType)) doesn't work here as some LL types seem opaque (forward-declared).
There was a problem hiding this comment.
That's strange, but I guess we'll roll with it for now.
kinke
changed the title
inboundsinbounds and add additional param attributes
dnadlinger
added a commit
that referenced
this pull request
Dec 30, 2015
Mark most GEPs `inbounds` and add additional param attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.