LDMD: Append default file extension if -of doesn't contain any #2002

kinke · 2017-02-17T16:21:17Z

Resolves issue #2001.

thewilsonator · 2017-02-17T23:48:31Z

Would be good to have tests for this.

kinke · 2017-02-18T00:06:29Z

I wanted to make sure all agree on this (not just for LDMD, but for LDC too) before adding the PITA tests.

thewilsonator · 2017-02-18T00:08:48Z

Do we not have the ability to do tests for only LDMD? or are you wanting to do this for both and hence waiting?

ghost · 2017-02-18T06:03:04Z

the tests should verify this:

command	Posix output	Windows Output
file.d -of=file	file	file.exe
file.d -of=file.plugin	file.plugin	file.plugin
file.d -lib -of=file.plugin	file.plugin	file.plugin
file.d -lib -of=file	file.a	file.lib

kinke · 2017-02-18T13:38:45Z

Do we not have the ability to do tests for only LDMD?

Of course, e.g., dmd-testsuite uses LDMD exclusively.

or are you wanting to do this for both and hence waiting?

This PR does it for both, as it's implemented in LDC, regardless of being invoked via LDMD or not. We could also keep the previous behavior of not tampering with the -of value (for LDC, not LDMD) in case some other tool relied on that, although I think that's highly unlikely as the static/dynamic libs or Windows executables are barely usable without extension.

@bbasile: You missed the DLL output case.

ghost · 2017-02-19T17:40:35Z

The corner case is just when a dot is present in the -of argument. Unfortunately I don't speak cpp but I have the feeling that you always add the right extension, which must not be done. The right extension is only added when no extension is already present (row 2 & 3).

ghost · 2017-02-19T17:44:07Z

Also a question: You seem make the change in a file that's not specific to LDMD. Does the fix only applies to LDMD ? (it should not affect LDC2).

kinke · 2017-02-19T17:44:47Z

Don't worry and don't rely on your feelings :], the extension is only added if the filename part doesn't contain a dot (see PR title...). DMD uses the same logic, and FileName::defaultExt() is implemented in the DMD front-end (https://github.com/ldc-developers/ldc/blob/master/ddmd/root/filename.d#L409).

kinke · 2017-02-19T17:50:23Z

Also a question

I already explained 2 posts further up...

JohanEngelen · 2017-02-19T18:17:29Z

I think LDC should do what other compilers do: no automatic file extension adding.

kinke · 2017-02-19T18:35:18Z

I think LDC should do what other compilers do: no automatic file extension adding.

Which ones did you check? If gcc and clang don't add anything, I very much agree.

JohanEngelen · 2017-02-19T19:20:20Z

I checked clang.

JohanEngelen · 2017-03-04T09:48:07Z

driver/cl_options.cpp

@@ -59,6 +59,9 @@ cl::list<std::string> runargs(
        "Runs the resulting program, passing the remaining arguments to it"),
    cl::Positional, cl::PositionalEatsArgs);

+cl::opt<bool> ldmd("ldmd", cl::desc("Invoked by LDMD?"), cl::ZeroOrMore,


could you rename the ldmd variable to invokedByLDMD or something else more descriptive?

kinke · 2017-03-04T14:50:38Z

https://github.com/ldc-developers/ldc/blob/master/driver/main.cpp#L1031 - shouldn't the default -shared output extension be .dylib instead of .so on OSX (Darwin)?

kinke · 2017-03-04T20:36:46Z

I'd say let's put this and (adapted) #2021 into 1.2 and then release the first alpha asap.

kinke · 2017-03-06T21:45:58Z

runtime/profile-rt/DefineBuildProfileRT.cmake

@@ -16,8 +16,6 @@ if (LDC_WITH_PGO)
        if (NOT (LDC_LLVM_VER GREATER 309))
            set(PROFRT_EXTRA_LDFLAGS "Ws2_32.lib")
        endif()
-    else()
-        set(PROFRT_EXTRA_FLAGS "-fPIC -O3")


Appropriate optimizations (for MSVC too) are already enforced - we rewrite all CMAKE_C_FLAGS_{DEBUG,MINSIZEREL,RELWITHDEBINFO} with ..._RELEASE in runtime/CMakeLists.txt (as the C parts of druntime/Phobos are always compiled in release too).

Resolves issue ldc-developers#2001.

Thus providing a generic way to slightly alter some command-line semantics in DMD compatibility mode.

The POSITION_INDEPENDENT_CODE target property seems to be supported since CMake 2.8.9, and Ubuntu 12.04 uses 2.8.7.

JohanEngelen reviewed Mar 4, 2017

View reviewed changes

kinke force-pushed the defaultExt branch from 8c7c732 to f6f3573 Compare March 4, 2017 12:30

kinke changed the title ~~Append default file extension if -of doesn't contain any~~ LDMD: Append default file extension if -of doesn't contain any Mar 4, 2017

kinke force-pushed the defaultExt branch from f6f3573 to cb694e9 Compare March 4, 2017 14:36

kinke mentioned this pull request Mar 4, 2017

Linux: Always build C parts of standard library as PIC #2009

Merged

kinke force-pushed the defaultExt branch 2 times, most recently from bd908b3 to 67454bf Compare March 4, 2017 19:16

JohanEngelen added this to the 1.2.0 milestone Mar 5, 2017

kinke commented Mar 6, 2017

View reviewed changes

kinke force-pushed the defaultExt branch 2 times, most recently from 308a81a to f16b2a4 Compare March 8, 2017 18:46

kinke added 5 commits March 8, 2017 19:47

Append default file extension if -of doesn't contain any

5f8cae7

Resolves issue ldc-developers#2001.

Add hidden -ldmd option when invoking LDC via LDMD

9a1c4ad

Thus providing a generic way to slightly alter some command-line semantics in DMD compatibility mode.

Append default file extension for LDMD only

7fc885e

Add dmd-testsuite tests for issue ldc-developers#2001

99acea7

Require CMake >= 2.8.9 and update Travis' CMake

647e3b6

The POSITION_INDEPENDENT_CODE target property seems to be supported since CMake 2.8.9, and Ubuntu 12.04 uses 2.8.7.

Darwin: Change default shared-lib extension from .so to .dylib

1c175b7

kinke force-pushed the defaultExt branch from f16b2a4 to 1c175b7 Compare March 8, 2017 18:47

kinke merged commit a75c84a into ldc-developers:master Mar 9, 2017

kinke deleted the defaultExt branch March 9, 2017 00:04

kinke mentioned this pull request Mar 9, 2017

inconsistent behavior of ldmd with -of, missing extension #2001

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LDMD: Append default file extension if -of doesn't contain any #2002

LDMD: Append default file extension if -of doesn't contain any #2002

kinke commented Feb 17, 2017

thewilsonator commented Feb 17, 2017

kinke commented Feb 18, 2017

thewilsonator commented Feb 18, 2017

ghost commented Feb 18, 2017

kinke commented Feb 18, 2017 •

edited

ghost commented Feb 19, 2017

ghost commented Feb 19, 2017

kinke commented Feb 19, 2017

kinke commented Feb 19, 2017

JohanEngelen commented Feb 19, 2017

kinke commented Feb 19, 2017

JohanEngelen commented Feb 19, 2017

JohanEngelen Mar 4, 2017 •

edited

kinke commented Mar 4, 2017 •

edited

kinke commented Mar 4, 2017

kinke Mar 6, 2017

LDMD: Append default file extension if -of doesn't contain any #2002

LDMD: Append default file extension if -of doesn't contain any #2002

Conversation

kinke commented Feb 17, 2017

thewilsonator commented Feb 17, 2017

kinke commented Feb 18, 2017

thewilsonator commented Feb 18, 2017

ghost commented Feb 18, 2017

kinke commented Feb 18, 2017 • edited

ghost commented Feb 19, 2017

ghost commented Feb 19, 2017

kinke commented Feb 19, 2017

kinke commented Feb 19, 2017

JohanEngelen commented Feb 19, 2017

kinke commented Feb 19, 2017

JohanEngelen commented Feb 19, 2017

JohanEngelen Mar 4, 2017 • edited

Choose a reason for hiding this comment

kinke commented Mar 4, 2017 • edited

kinke commented Mar 4, 2017

kinke Mar 6, 2017

Choose a reason for hiding this comment

kinke commented Feb 18, 2017 •

edited

JohanEngelen Mar 4, 2017 •

edited

kinke commented Mar 4, 2017 •

edited