Adapt embedded llvm-ar to LLVM 5.0 final #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch gets rid of the paths and fixes the issue I had with llvm 5.0, tested and confirmed locally. |
|
LTO on OSX has troubles with same-name objects in archives indeed. But it's a linker issue (quite sure), perhaps with XCode 9, the problem is gone. Can't test right now though :/ Edit: or perhaps it did have to do with how we create the phobos archive... Will be testing again soon. Editedit: nope, still doesn't work with LLVM5 + XCode 8. Needs an LLVM fix or linker fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was based on early LLVM 5.0, and there's been one notable change in the meantime, see https://reviews.llvm.org/D33575. I think @joakim-noah mentioned some issues wrt. object names in static libs. Edit: And @JohanEngelen something wrt. object names and LTO?