Jit bind #2726

Hardcode84 · 2018-06-06T18:09:19Z

bind-like functionality which allow to generate efficient specialized versions of functions (much like easy::jit).

Add ldc.dynamic_compile.bind function with interface similar to C++ std::bind. Function returns BindPtr object (which is reference counted internally) with opCall method.

Actual body is generated during compileDynamicCode and after that BindPtr can be called.
Function passed to bind must be marked @dynamicCompile, otherwise BindPtr.isCallable() will return false and 'opCall' asserts.

If function bind as parameter marked as @dynamicCompile it will be efficiently optimized (see dynamiccompile/bind_func_opt.d test).

Also bind functions can be chained together (see dynamiccompile/bind_nested_opt.d test).

Hardcode84 · 2018-06-10T07:00:21Z

Ready, I think.

JohanEngelen · 2018-06-10T11:43:41Z

Great that you submitted some parts as separate PRs.
Quickly glancing over it, I missed documentation of the new user function bind.

JohanEngelen · 2018-06-10T11:43:54Z

runtime/jit-rt/d/ldc/dynamic_compile.d

@@ -83,10 +83,306 @@ void compileDynamicCode(in CompilerSettings settings = CompilerSettings.init)
  rtCompileProcessImpl(context, context.sizeof);
 }

+auto bind(F, Args...)(F func, Args args)


JohanEngelen · 2018-06-10T11:44:07Z

runtime/jit-rt/d/ldc/dynamic_compile.d

+auto bind(F, Args...)(F func, Args args)
+{
+  import std.format;
+  static assert(isFunctionPointer!F);


nice to add a message to the user when this fails

JohanEngelen · 2018-06-10T11:44:47Z

runtime/jit-rt/d/ldc/dynamic_compile.d

+  alias FuncParams = Parameters!(F);
+  alias Ret = ReturnType!F;
+  F func = null;
+  static assert(func.offsetof == 0, "func must be fist");


typo in error msg

Hardcode84 · 2018-06-10T13:33:26Z

just rebase (and something bad happened with commit dates so github display nonsense like 8 days ago)

Hardcode84 · 2018-06-13T21:12:24Z

rebased, added docs

JohanEngelen · 2018-06-15T12:41:32Z

runtime/jit-rt/d/ldc/dynamic_compile.d

+  return BindPtrType.make!Index(func, mapBindParams!(F, 0)(args).expand);
+}
+
+immutable placeholder = _placeholder();


This member should also be documented briefly. Probably just a reference to bind.

Hardcode84 · 2018-06-27T15:53:46Z

Updated: delegate as first parameter, @dynamicCompileEmit, some docs

Hardcode84 · 2018-08-28T19:29:29Z

Rebased.

TODO: probably need to write some design overview

Hardcode84 · 2018-09-04T17:34:29Z

ready

JohanEngelen · 2018-09-04T21:04:13Z

runtime/jit-rt/cpp-so/bind.h

@@ -0,0 +1,27 @@
+#ifndef BIND_H


missing header

JohanEngelen · 2018-09-04T21:05:13Z

runtime/jit-rt/cpp-so/param_slice.h

+//
+//===----------------------------------------------------------------------===//
+//
+// ParamSlice declaration.


;-) nitpick: this comment is useless, I can read the same a few lines down in C++. What would help is to explain what ParamSlice is used for.

JohanEngelen · 2018-09-04T21:09:51Z

docs/dynamic_compile_bind.md

@@ -0,0 +1,25 @@
+# Dynamic compile bind


I like that you added some design documentation

JohanEngelen · 2018-09-04T21:10:12Z

CMakeLists.txt

@@ -405,7 +405,7 @@ if(LDC_DYNAMIC_COMPILE STREQUAL "AUTO")
    if (NOT (LDC_LLVM_VER LESS 500))
        set(LDC_DYNAMIC_COMPILE True)
        add_definitions(-DLDC_DYNAMIC_COMPILE)
-        add_definitions(-DLDC_DYNAMIC_COMPILE_API_VERSION=1)
+        add_definitions(-DLDC_DYNAMIC_COMPILE_API_VERSION=2)


Make sure to add an item about this to the release notes.

JohanEngelen · 2018-09-04T21:18:08Z

I've made some grammar fixes to the documentation.
Overall, I think it's fine to include, I didn't do a review of the actual tech content of this PR. I trust you know what you are doing :)

JohanEngelen · 2018-09-04T21:19:12Z

See some inline comments.

… later (needed for bind)

Hardcode84 changed the title ~~WIP: Jit bind~~ Jit bind Jun 9, 2018

JohanEngelen reviewed Jun 10, 2018

View reviewed changes

Hardcode84 force-pushed the jit_bind2 branch from 653c5d4 to 26b8a90 Compare June 10, 2018 13:24

Hardcode84 force-pushed the jit_bind2 branch from 26b8a90 to 7be3d33 Compare June 13, 2018 21:08

JohanEngelen reviewed Jun 15, 2018

View reviewed changes

Hardcode84 mentioned this pull request Jun 15, 2018

dynamicCompile and ref args segfault #2749

Open

Hardcode84 force-pushed the jit_bind2 branch from 7be3d33 to 56bccea Compare June 27, 2018 15:51

Hardcode84 force-pushed the jit_bind2 branch from 56bccea to 66bf145 Compare August 28, 2018 19:18

Hardcode84 force-pushed the jit_bind2 branch from b29b3df to 1bb464f Compare September 4, 2018 17:30

JohanEngelen reviewed Sep 4, 2018

View reviewed changes

docs/dynamic_compile_bind.md

@@ -0,0 +1,25 @@

# Dynamic compile bind

Copy link

Member

JohanEngelen Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you added some design documentation

JohanEngelen reviewed Sep 4, 2018

View reviewed changes

Hardcode84 force-pushed the jit_bind2 branch from 42f6b52 to 70f5dbb Compare September 5, 2018 16:29

Hardcode84 added 5 commits September 5, 2018 19:51

jit bind D part and C++ stubs

6734cd1

Add thunks to symbol list

e453edc

bindInstaces

bdc5f65

store thunk func ptr in jit metadata

a27d649

func map

c6a454b

test

6e52f7f

Hardcode84 force-pushed the jit_bind2 branch from 70f5dbb to 42f34c8 Compare September 5, 2018 17:10

Hardcode84 and others added 20 commits September 6, 2018 21:21

basic bind works!

28abe2c

structs support

f102c3d

more tests

3c521d7

delegate support and some cleanup

1d8866e

example func to properly propagate attributes

c682615

Bind optimization test

eb211c8

optimize bind functions

0c8c8e8

add internal functions to jit functions list so they can be retrieved…

5c9cd62

… later (needed for bind)

nested binds

0184e07

increase jit api version

b613a53

clang format

91c1b8e

doc

3c179e8

@dynamicCompileEmit handling in generateSymList

a9acd58

remove dummyDel hack

a4a4d6b

reverse params order and non-dynamic functions support in bind

9386295

fix bind for @dynamicCompileEmit

355b4cb

delegate support

2ed80c1

docs

6c03353

some docs

a145d4a

Try to improve documentation

08695cd

Hardcode84 force-pushed the jit_bind2 branch from 42f34c8 to 08695cd Compare September 6, 2018 18:27

Hardcode84 merged commit 3fa6b26 into ldc-developers:master Sep 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jit bind #2726

Jit bind #2726

Hardcode84 commented Jun 6, 2018 •

edited

Hardcode84 commented Jun 10, 2018

JohanEngelen commented Jun 10, 2018

JohanEngelen Jun 10, 2018

Hardcode84 Jun 13, 2018

JohanEngelen Jun 10, 2018

Hardcode84 Jun 13, 2018

JohanEngelen Jun 10, 2018

Hardcode84 Jun 13, 2018

Hardcode84 commented Jun 10, 2018

Hardcode84 commented Jun 13, 2018

JohanEngelen Jun 15, 2018

Hardcode84 Jun 27, 2018

Hardcode84 commented Jun 27, 2018

Hardcode84 commented Aug 28, 2018

Hardcode84 commented Sep 4, 2018

JohanEngelen Sep 4, 2018

Hardcode84 Sep 5, 2018

JohanEngelen Sep 4, 2018

Hardcode84 Sep 5, 2018

JohanEngelen Sep 4, 2018

JohanEngelen Sep 4, 2018

JohanEngelen commented Sep 4, 2018

JohanEngelen commented Sep 4, 2018

Jit bind #2726

Jit bind #2726

Conversation

Hardcode84 commented Jun 6, 2018 • edited

Hardcode84 commented Jun 10, 2018

JohanEngelen commented Jun 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hardcode84 commented Jun 10, 2018

Hardcode84 commented Jun 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hardcode84 commented Jun 27, 2018

Hardcode84 commented Aug 28, 2018

Hardcode84 commented Sep 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JohanEngelen commented Sep 4, 2018

JohanEngelen commented Sep 4, 2018

Hardcode84 commented Jun 6, 2018 •

edited