[macOS] CMake: Work around ranlib potentially corrupting static libs #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perhaps you wanted to target lgtm |
|
Nope, this is done as part of remaining 2.081 OSX troubleshooting (dynamic-compile integration tests fail for Circle, once again due to a ranlib-corrupted static lib in the install folder when using the integrated archiver...). [We need the internal archiver for |
Cross-checked against LLVM 6.0.0.
When installing the static lib archived by LDC (1 D object file, 1 C++ one) via CMake, `ranlib` is apparently invoked for the installed copy, which may corrupt it, e.g., reproduced via CircleCI SSH with Xcode 9.2 (.a file size unchanged after (successful) ranlib run): /Applications/Xcode-9.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: foo.a truncated or malformed archive (terminator characters in archive member "c_" not the correct "`\n" values for the archive member header at offset 784) We already encountered this or a very similar bug (with LLVM 5 and some Xcode version IIRC). Copy the file manually for now as hopefully robust workaround.
kinke
changed the title
kinke
changed the title
I.e., druntime and Phobos too, not just ldc-jit-rt. [Only affecting MULTILIB=OFF builds, as the fat libs are generated and copied manually anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cross-checked against LLVM 6.0.0 (no relevant changes though).