Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-fvisibility=hidden: Hide init symbols, TypeInfos and vtables too if the associated aggregate isn't exported #3129

Merged
merged 1 commit into from
Aug 19, 2019
Merged

-fvisibility=hidden: Hide init symbols, TypeInfos and vtables too if the associated aggregate isn't exported #3129

merged 1 commit into from
Aug 19, 2019

Conversation

kinke
Copy link
Member

@kinke kinke commented Aug 10, 2019

Fixes #3122.

@kinke
Copy link
Member Author

kinke commented Aug 10, 2019

Pinging @skoppe.

@skoppe
Copy link
Contributor

skoppe commented Aug 10, 2019

Nice! Gonna try out right away. Any chance this is going to be part of 1.17?

@kinke
Copy link
Member Author

kinke commented Aug 10, 2019

Quite likely, in case it works for you/spasm.

@skoppe
Copy link
Contributor

skoppe commented Aug 10, 2019

Works like a charm!

@kinke
Copy link
Member Author

kinke commented Aug 10, 2019

Nice, thx for testing.

@kinke kinke force-pushed the hide_globals branch 2 times, most recently from 52a3540 to a8dd0b1 Compare August 11, 2019 11:18
@kinke kinke mentioned this pull request Aug 11, 2019
Merged
@kinke kinke merged commit c172580 into ldc-developers:master Aug 19, 2019
@kinke kinke deleted the hide_globals branch August 19, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webassembly and --export-dynamic causes too much bloat
2 participants
@kinke @skoppe