Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with LLVM 13+: some errors in inline assembly don't stop compilation #4331

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Fix regression with LLVM 13+: some errors in inline assembly don't stop compilation #4331

merged 1 commit into from
Feb 26, 2023

Conversation

kinke
Copy link
Member

@kinke kinke commented Feb 26, 2023

Based on Luís' #4302.

@kinke kinke changed the title Fix regression with LLVM 13+: Return non-zero exit code for inline asm errors Fix regression with LLVM 13+: some errors in inline assembly don't stop compilation Feb 26, 2023
@kinke
Copy link
Member Author

kinke commented Feb 26, 2023

We already have a bunch of inline asm diagnostic fail_compilation tests, also testing the exit code - so looks like we only missed a subset of the LLVM errors.

@kinke kinke merged commit 7d3f5ba into ldc-developers:master Feb 26, 2023
@kinke kinke deleted the fix4293 branch February 26, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kinke @thewilsonator