Fix LTO on newer macOS. #4548
Merged
Fix LTO on newer macOS. #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trouble was that the libLTO-ldc.dylib was not used by ld64, even though it is explicitly passed using -lto_library. Somehow the library renaming (adding "-ldc" postfix) is not working properly. I did not figure out how to fix it (the usual install-name-tool and resigning did not work), the only fix that worked is to not rename it at all. This bug went unnoticed because at -O0, there is no LTO object file output at all; hence the -O3 addition to the thinlto testcase.
This was referenced Jan 27, 2024
JohanEngelen
added a commit
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trouble was that the libLTO-ldc.dylib was not used by ld64, even though it is explicitly passed using -lto_library. Somehow the library renaming (adding "-ldc" postfix) is not working properly. I did not figure out how to fix it (the usual install-name-tool and resigning did not work), the only fix that worked is to not rename it at all. This bug went unnoticed because at -O0, there is no LTO object file output at all; hence the -O3 addition to the thinlto testcase.