Fix glibc assert: __assert -> __assert_fail #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, glibc would use __assert, which causes a segmentation fault due to strange internal behavior between D and C compilers. It is better practice to use __assert_fail. See #16515 of dlang/dmd.
thewilsonator
approved these changes
May 23, 2024
kinke
reviewed
May 23, 2024
|
Is there an upstream test for this? |
|
No there is not |
kinke
added a commit
to kinke/ldc
that referenced
this pull request
Jun 12, 2024
Introduced in ldc-developers#4667 and reported in the announce dlang forum.
kinke
added a commit
that referenced
this pull request
Jun 13, 2024
Introduced in #4667 and reported in the announce dlang forum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldc2 returns SIGSEGV instead of SIGABRT for any value of
assert in betterC (or -checkaction=C or defaultlib="" ...)
due to some improper usage of __assert. As per the C compilers,
(gcc, clang, etc.), __assert_fail should be used for C asserts.
See my related PR for DMD:
dlang/dmd#16515