[LDC] PGO: Avoid COMDATs with private linkage (fixing PGO for Windows)

ldc-developers · Sep 20, 2019 · f21cbc0 · f21cbc0
1 parent 83aee82
commit f21cbc0
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/ProfileData/InstrProf.cpp b/lib/ProfileData/InstrProf.cpp
@@ -312,9 +312,14 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
     Linkage = GlobalValue::LinkOnceAnyLinkage;
   else if (Linkage == GlobalValue::AvailableExternallyLinkage)
     Linkage = GlobalValue::LinkOnceODRLinkage;
+  /* LDC: use `internal` instead of `private` linkage (still local, but allows
+          for COMDATs, and is required for Windows)
   else if (Linkage == GlobalValue::InternalLinkage ||
            Linkage == GlobalValue::ExternalLinkage)
     Linkage = GlobalValue::PrivateLinkage;
+  */
+  else if (Linkage == GlobalValue::ExternalLinkage)
+    Linkage = GlobalValue::InternalLinkage;
 
   auto *Value =
       ConstantDataArray::getString(M.getContext(), PGOFuncName, false);