Fixed bug with pretty formatter output in scenario without a background

ldegen · Dec 11, 2012 · 260b595 · 260b595
1 parent 9403fa5
commit 260b595
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/cucumber/listener/pretty_formatter.js b/lib/cucumber/listener/pretty_formatter.js
@@ -29,7 +29,13 @@ var PrettyFormatter = function(options) {
   self.handleBeforeScenarioEvent = function handleBeforeScenarioEvent(event, callback) {
     var scenario = event.getPayloadItem('scenario');
     var source = scenario.getKeyword() + ": " + scenario.getName();
-    currentMaxStepLength = scenario.getMaxStepLength() > scenario.getBackground().getMaxStepLength() ? scenario.getMaxStepLength() : scenario.getBackground().getMaxStepLength();
+    var lineLengths = [source.length, scenario.getMaxStepLength()];
+    if(scenario.getBackground() !== undefined) {
+      lineLengths.push(scenario.getBackground().getMaxStepLength());
+    }
+    lineLengths.sort(function(a,b) { return b-a; });
+    currentMaxStepLength = lineLengths[0];
+
     source = self._pad(source, currentMaxStepLength + 3);
 
     if(options['logToConsole'])

diff --git a/spec/cucumber/listener/pretty_formatter_spec.js b/spec/cucumber/listener/pretty_formatter_spec.js
@@ -112,7 +112,8 @@ describe("Cucumber.Listener.PrettyFormatter", function () {
     beforeEach(function () {
       keyword  = "scenario-keyword";
       name     = "scenario-name";
-      backgroundStepLength = 30;
+      //Background step assumed to be the longest
+      backgroundStepLength = 40;
       scenarioStepLength = 20;
       line = 10
       uri = "scenario-uri";