cannot pad with '/' in title

[ynnk]

Probably a etherpad-lite bug, but affect also your project

• create a pad either in etherpad lite or etherpad admin named 'fail/json'

you cannot acces the pad nor delete it.

• url look like /pad/p/fail/&iejson
• should remove the last '/' to work /pad/p/fail&iejson

ynnk

[JohnMcLear]

afaik pad ids should be sanitized, the api should return a failure or return a sanitized padid when you make this.

[ynnk]

So i need to open an issue in etherpad-lite ?

[JohnMcLear]

nope, prolly needs resolving here

[ldidry]

Sure. I'll take a look tonight.

[ynnk]

any ideas on how to remove pads created with wrong ids ?
i tryed removing entries in redis
$ redis-cli keys 'pad:*fail*' | cut -d')' -f1 | xargs redis-cli del
... but pads are still listed

Thx Luc & John

[ldidry]

Install URI::Encode via cpan or liburi-encode-perl in Debian or Ubuntu cause it's now a dependancy.

@JohnMcLear :

the api should return a failure or return a sanitized padid when you make this.

No, it's not returning a sanitized padid :

curl "http://127.0.0.1:1234/api/1/createPad?apikey=xxx&padID=foo/o"
{"code":0,"message":"ok","data":null}#

[ldidry]

shit, wait. some url problems

[ldidry]

@ynnk : You'll be able to delete your bad pads from etherpad::admin now 😃

[ynnk]

Bjr Luc

Actually this patch is not enough

• i can t remove old pads created with '/' or '&' in names
  maybe it related , but i tried to delete keys from redis before your commited a patch. ( see upper comment )
  but all theses pads can be edited and saved in etherpad-lite.
• creating a new pad from etherpad-lite named test&fail
  it works you can edit and save,
  but test&fail is not deletable from etherpad-admin url is /pad/p/test%26fail3

for all case api (message in boostrap style ) says that the pad has been deleted

yk

[ldidry]

Indeed, with & you can't see or delete a pad. I'll see that.

[ldidry]

Ok. the '&' thing was Etherpad::API fault.
I uploaded version 0.10 to the CPAN right now, so you have to wait a little bit to be able to upgrade.

Don't forgot to restart etherpad-admin after upgrading Etherpad::API.

I hope it will be ok for you (it was ok for me, but who knows ?)