Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Remove service calls #18

Merged
merged 9 commits into from
Jan 17, 2020
Merged

Remove service calls #18

merged 9 commits into from
Jan 17, 2020

Conversation

ineiti
Copy link
Contributor

@ineiti ineiti commented Jan 14, 2020

  • passing extended config when starting protocol
  • SurveyDDT w/o service-messages
  • SurveyAggRequest de-serviced
  • ShuffleRequest w/o service-messages

Also includes #17
Closes #17
Closes #12

@ineiti ineiti self-assigned this Jan 14, 2020
@mickmis
Copy link
Contributor

mickmis commented Jan 14, 2020

Thanks for your work @ineiti @JoaoAndreSa.

I see that one of the Travis check is failing. Are those two Travis builds (pr and push) supposed to be the same? Did the tests run fine on your local machine? If so, since one is failing and the other is succeeding, that might the random bug we are trying to track down @JoaoAndreSa.

@JoaoAndreSa
Copy link
Contributor

no apparently is something else now... @ineiti any idea? It's stuck in the aggregation request

@ineiti ineiti force-pushed the remove_service_calls branch 14 times, most recently from 5e10dab to 488180a Compare January 15, 2020 08:22
@ineiti
Copy link
Contributor Author

ineiti commented Jan 15, 2020

Working on it - have a first small fix. Might be an error triggered rarely in onet...

@ineiti ineiti force-pushed the remove_service_calls branch 3 times, most recently from 4f4671e to 8ffb194 Compare January 15, 2020 13:10
@ineiti
Copy link
Contributor Author

ineiti commented Jan 15, 2020

Found a test-case that fails in dedis/onet#609

@ineiti
Copy link
Contributor Author

ineiti commented Jan 16, 2020

And a fix in dedis/onet#611 - keeping the time.Sleep for the moment...

@JoaoAndreSa JoaoAndreSa changed the base branch from master to dev January 16, 2020 10:08
@JoaoAndreSa
Copy link
Contributor

JoaoAndreSa commented Jan 16, 2020

@mickmis I think you can merge this to dev (and then master) and delete #17 and #12

@ineiti
Copy link
Contributor Author

ineiti commented Jan 16, 2020

@mickmis I think you can merge this to dev (and then master) and delete #17 and #12

You can add a Closes #12 to the description of the PR, and this will be done automatically ;)

@mickmis
Copy link
Contributor

mickmis commented Jan 17, 2020

Alright, thanks. @ineiti if I get it it correctly, you have put a temporary fix in this PR for the bug in question, and a permanent one is subject to a PR in onet's repo?

Just to know to remove the temporary fix when the onet PR will be accepted and a new version released.

@mickmis mickmis merged commit cfdfe26 into dev Jan 17, 2020
@JoaoAndreSa JoaoAndreSa deleted the remove_service_calls branch January 21, 2020 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants