simpler solution to the configuration problem #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
config_error_simple
branch
3 times, most recently
from
742b754
to
0e7d35e
Compare
ineiti
force-pushed
the
config_error_simple
branch
from
0e7d35e
to
df120ef
Compare
ineiti
force-pushed
the
config_error_simple
branch
from
df120ef
to
dc7ae9b
Compare
This was referenced Jan 16, 2020
jeffallen
approved these changes
Jan 24, 2020
mickmis
added a commit
to ldsec/medco-unlynx
that referenced
this pull request
Jan 31, 2020
mickmis
added a commit
to ldsec/medco
that referenced
this pull request
Sep 30, 2020
Former-commit-id: e33e4fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #610
This is a much simpler version than #609. Instead of sending two messages serially, which can get two different connections, it extends the signature of
Router.Sendto a variadic number of messages to send.-> Backwards compatible
-> passes test