-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dictionary functionality to Rule(6) class #222
Conversation
Did you try running tests locally? They failed on Travis:
|
I ran the test on my system for both python2 (2.7.12) and python3 (3.5.2). They ran ok, all of them :)
|
Sorry for the delay on my part, I'd like to look into the failures in the Travis CI build. They look like segfaults when running the test suite. |
It seems the build issues have been resolved and now there are no conflicts. I have also improved the dictionary generation function to remove empty lists and fields. |
Nice! Can you also add tests for the dict methods, and a few lines to |
Added example of use
I completely forgot about this PR, sorry about that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
This commit adds the dictionary functionality to Rule() and Rule6() classes.
This addresses a previous feature request reported in issue #219