-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete refactorization for css/grayscale.scss and sorted sections in index.html #56
Conversation
joariasl
commented
Nov 10, 2015
- Complete refactorization for css/grayscale.scss
- Sections display in sorted of the configuration
- Remove unnecessary id tags
- Update exclusion list
- Update in scripts/newpost
- Added separator in pagination
- Auto toggle to navbar-collapse on ready event. For url of type: file.html#element-id
Change col size to "col-lg-10 col-lg-offset-1"
I copied the IronSummitMedia/startbootstrap-grayscale/blob/gh-pages/less/grayscale.less file and I applied the changes for { Personal } style. I remove unused CSS Grayscale definitions: .download-section ul.banner-social-buttons Fixed bugs of the original Grayscale style Close le4ker#13
Work transmited on LiveCoding.tv: https://www.livecoding.tv/video/personal-jekyll-theme-9/ |
Removed: * .light * .download-section * #map
New text-shadow rules for: * .navbar-custom a * .intro .intro-body .intro-text
9732995
to
240380b
Compare
8f1515f
to
760ff35
Compare
* Params for configure background color in header and nav * Background img is used only if it is defined in _config.yml
@@ -360,10 +282,6 @@ footer { | |||
background: rgba($light, 0.2); | |||
} | |||
|
|||
img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need that, in order to make the images in the posts responsive. It's a fix for issue #36
Apart from the image regression, the lists in the post don't render correctly. Here is the screenshot from my blog when running locally with the new changes |
I understand. He had seen that definition. Do you think using a class to the container of the post and assign the style to their internal images? .content-section img {
display: block;
max-width: 100%;
height: auto;
} I use the original definition of Bootstrap 3: https://github.com/twbs/bootstrap/blob/master/less/mixins/image.less#L9 |
Added commit in the Pull Request. And deleted unecesary duplication ID in post.html and blog.html. |
* .content-section img definition in grayscale.scss * Remove unecesary duplicated id="{{ page.title }}" definition in posts.html and blog.html
The content in index.html is now sorted in _config.yml pages_list order. * Close le4ker#40 issue * Moved latest-posts to latest-post.html for conflict with blog.html * Changed the ID in sections for page.section-type * Subtracted 50 in offset Scrollspy
Closed le4ker#57 issue
f9d9439
to
0ce1862
Compare
If the scroll is downed in te load page the navbar is collapse
The border buttom use one pixel and generated problem in mobile version. Fixed!