Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete refactorization for css/grayscale.scss and sorted sections in index.html #56

Merged
merged 31 commits into from
Nov 14, 2015

Conversation

joariasl
Copy link
Collaborator

  • Complete refactorization for css/grayscale.scss
  • Sections display in sorted of the configuration
  • Remove unnecessary id tags
  • Update exclusion list
  • Update in scripts/newpost
  • Added separator in pagination
  • Auto toggle to navbar-collapse on ready event. For url of type: file.html#element-id

Change col size to "col-lg-10 col-lg-offset-1"
I copied the IronSummitMedia/startbootstrap-grayscale/blob/gh-pages/less/grayscale.less file and I applied the changes for { Personal } style.

I remove unused CSS Grayscale definitions:
 .download-section
 ul.banner-social-buttons

Fixed bugs of the original Grayscale style

Close le4ker#13
@joariasl
Copy link
Collaborator Author

@joariasl joariasl changed the title Fixed issues Complete refactorization for css/grayscale.scss Nov 11, 2015
Removed:
* .light
* .download-section
* #map
New text-shadow rules for:
* .navbar-custom a
* .intro .intro-body .intro-text
@joariasl joariasl force-pushed the master branch 2 times, most recently from 9732995 to 240380b Compare November 11, 2015 06:32
@joariasl joariasl force-pushed the master branch 3 times, most recently from 8f1515f to 760ff35 Compare November 11, 2015 07:35
* Params for configure background color in header and nav
* Background img is used only if it is defined in _config.yml
@@ -360,10 +282,6 @@ footer {
background: rgba($light, 0.2);
}

img {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need that, in order to make the images in the posts responsive. It's a fix for issue #36

@le4ker
Copy link
Owner

le4ker commented Nov 11, 2015

Apart from the image regression, the lists in the post don't render correctly.
Actually that was a bug from the Timeline repo that I initially forked and it was tracked by issue #14 😋

Here is the screenshot from my blog when running locally with the new changes

@joariasl
Copy link
Collaborator Author

I understand. He had seen that definition.
The correct is to use <img class="img-responsive" ...> (using ![Picture description](/link/to/picture.jpg){: .img-responsive }) in the images. But we must maintain backward compatibility.

Do you think using a class to the container of the post and assign the style to their internal images?

.content-section img {
  display: block;
  max-width: 100%;
  height: auto;
}

I use the original definition of Bootstrap 3: https://github.com/twbs/bootstrap/blob/master/less/mixins/image.less#L9

@joariasl
Copy link
Collaborator Author

Added commit in the Pull Request. And deleted unecesary duplication ID in post.html and blog.html.

* .content-section img definition in grayscale.scss
* Remove unecesary duplicated id="{{ page.title }}" definition in posts.html and blog.html
The content in index.html is now sorted in _config.yml pages_list order.

* Close le4ker#40 issue
* Moved latest-posts to latest-post.html for conflict with blog.html
* Changed the ID in sections for page.section-type
* Subtracted 50 in offset Scrollspy
@joariasl joariasl changed the title Complete refactorization for css/grayscale.scss Complete refactorization for css/grayscale.scss and sorted sections in index.html Nov 13, 2015
@joariasl joariasl force-pushed the master branch 2 times, most recently from f9d9439 to 0ce1862 Compare November 13, 2015 08:09
If the page is distinct to index.html, Blog item of navigation redirect to blog/index.html
le4ker pushed a commit that referenced this pull request Nov 14, 2015
Complete refactorization for css/grayscale.scss and sorted sections in index.html Fixes #40 #48 #57
@le4ker le4ker merged commit 4ba5b71 into le4ker:master Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants