This repository has been archived by the owner on May 18, 2019. It is now read-only.
New Preferences system #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2015
Closed
|
Nice! :) |
|
For complete documentation sake, this PR also changes how the plugin is installed, and as such it will require the user to uninstall any previous versions. However, this will help out in the long run. |
+ Small refactoring to load new script + Change all debugPrint calls to Console.log - Remove debugPrint Small bug fixes More bug fixes, new methods Incorporate the new preferences system Rename class to more logical name Update setup.py for script changes Also trim out number of files added Use the version defined in __version__.py Add importOps key to dictionary
added 2 commits
August 22, 2015 11:43
Conflicts: import_ldraw.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
src/ldutils.pymodule containing a new preferences system and relocated message logger.This new script started out for a different but related (and unfinished) project, but I decided to incorporate it in here.
This replaces the old, hacky, and unsafe
exec(compile(lines, config_filename, 'exec'))system by using a newpref/LDR-Importer.jsonfile and properly loading it into the script. There is room for expansion as needed. This also improves the LDraw install detection on Win, Mac, and Linux and moves thedebugPrintfunction to aConsole.logmethod.This required a bit of refactoring to set up, but that should not have a major (if any) effect on other PRs. The only real code effects will be
debugPrint()is no longer a function and will need to be replaced with the new method right before/after merging.I have not yet updated the packaging script but will do so.I have fully tested this on Windows 7 x64 and Blender 2.72 and 2.75a as well as under Python 3.4.3 outside of Blender context.
Bonus: the script is now ~1024 lines instead of 1202. 😄
@tribex You'll probably be interested in this as (IIRC) you initially added the old preferences system.