Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is L.Provided really useful enough to keep it? #103

Closed
jieter opened this issue Aug 22, 2014 · 3 comments
Closed

Is L.Provided really useful enough to keep it? #103

jieter opened this issue Aug 22, 2014 · 3 comments

Comments

@jieter
Copy link
Contributor

jieter commented Aug 22, 2014

I've never used it and it's close to 10% of the code size:

Current size:

13924 leaflet-providers.js
 9408 leaflet-providers.min.js
 3074 leaflet-providers.min.js.gz

After removing L.Provided

12538 leaflet-providers.js        (-1386)
 8680 leaflet-providers.min.js    ( -728)
 2831 leaflet-providers.min.js.gz ( -243)

Thoughts @calvinmetcalf, @brunob?
@brunob
Copy link
Member

brunob commented Aug 22, 2014

Same for me, i think we can remove it and bump a X in the script version to mark the compatibility break.

@jieter
Copy link
Contributor Author

jieter commented Aug 26, 2014

@calvinmetcalf objections?

@calvinmetcalf
Copy link
Member

yeah get rid of it

@jieter jieter closed this as completed in 95eb7ad Aug 26, 2014
jieter added a commit that referenced this issue Aug 26, 2014
@jieter
Merge pull request #108 from leaflet-extras/remove-control
824c680 
Remove L.Provided fixes #103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brunob @calvinmetcalf @jieter