Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 5 free basemaps from Nokia #18

Merged
merged 2 commits into from Feb 28, 2013
Merged

Added 5 free basemaps from Nokia #18

merged 2 commits into from Feb 28, 2013

Conversation

WanderingHogan
Copy link

I added 5 Free base maps from Nokia's Developers.here.com site that I have been using.

Basemaps are:
Normal Day
Normal Day Grey
Satellite
Satellite with Labels
Terrain

You can sign up for a free developers key and app id or not, it works without.

@calvinmetcalf
Copy link
Member

This looks fine to me anyone object ?

@brunob
Copy link
Member

brunob commented Feb 23, 2013

Great, thanks for the pull req, seems fine to merge for me too :)

Just a question, what's the difference if we use it without a dev key ? / I think i've found the answer to this question here : http://developer.here.com/faqs

Anyway, i just want to be sure that the TOS of Nokia let us play with their tiles without using their API, did you have anyy information about that @ChrisCarto ?

@calvinmetcalf
Copy link
Member

good catch it doesn't seem to say anywhere that you can use it without an appkey, i.e. is it subject to change without notice

EDIT
to be clear, I think we can put this in even if that is the case, we'd just need to put a note in the documentation.

@calvinmetcalf
Copy link
Member

@ChrisCarto the filename just got changed, your going to need to run

git fetch upstream
git push origin/master

if you don't have upstream set up you'll need to run

git remote add upstream git://github.com/leaflet-extras/leaflet-providers.git 

apologies if you already know how to do this.

@WanderingHogan
Copy link
Author

Thank you - sorry for the delay. Just added and fetched upstream then pushed

@calvinmetcalf
Copy link
Member

sorry, I missed a step, git merge upstream/master

calvinmetcalf pushed a commit that referenced this pull request Feb 28, 2013
Added 5 free basemaps from Nokia
@calvinmetcalf calvinmetcalf merged commit b829108 into leaflet-extras:master Feb 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants