don't put extra ? at end of url with empty query params in url_for

leafo · Jun 5, 2015 · 959b223 · 959b223
1 parent db8626b
commit 959b223
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lapis/router.moon b/lapis/router.moon
@@ -99,8 +99,9 @@ class Router
     if query
       if type(query) == "table"
         query = encode_query_string query
-      path ..= "?" .. query
 
+      if query != ""
+        path ..= "?" .. query
     path
 
   resolve: (route, ...) =>

diff --git a/spec/routes_spec.moon b/spec/routes_spec.moon
@@ -120,6 +120,10 @@ describe "named routes", ->
     url = r\url_for "profile", { name: "adam" }, "required"
     assert.same "/profile/adam?required", url
 
+  it "generates url with empty query params", ->
+    url = r\url_for "profile", { name: "adam" }, {}
+    assert.same "/profile/adam", url
+
   it "should create param from object", ->
     user = {
       url_key: (route_name, param_name) =>