Avfile missing data #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge form leancloud
zqq90
suggested changes
Aug 11, 2017
| return new JSONObject(toHashMap()); | ||
| } | ||
|
|
||
| public Map<String, Object> toHashMap() { |
| case StorageTypeS3: | ||
| file.setName((String) map.get(AVObject.OBJECT_ID)); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
健壮性: 这里 switch 需要列举出所有 StorageType，然后 default 块抛出不支持此类型的异常，
即使是不需要的处理也要直接break，
目的是防止日后新增类型之后没有因没有改动此处逻辑导致一些无法捕捉的事后 bug
| // we store the objectId in file.name | ||
| result.put("id", getName()); | ||
| break; | ||
| default: |
| * "51a306fce4b06e53feb1d95f", "updatedAt": "2013-05-27T07:10:52.000Z", "url": | ||
| * "https://s3-ap-northeast-1.amazonaws.com/avos-cloud/b60b1e29-5314-4538-9759-2cb6d6c74185" } | ||
| */ | ||
| public static Map<String, Object> mapFromFile(AVFile file) { |
There was a problem hiding this comment.
建议保留方法，并标注@Deprecated，实现可以直接换成 file.toMap()
| return result; | ||
| } | ||
|
|
||
| public static AVFile fileFromMap(Map<String, Object> map) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要修复的问题：AVFile 与 HashMap 转换时部分字段丢失。
另外，AVFile 与 HashMap 转换的代码从 AVUtils 迁移到了 AVFile。