Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csharpier check formatting step #619

Closed
wants to merge 2 commits into from

Conversation

wojtek2288
Copy link
Contributor

Well this is ugly.

Copy link

Test Results

  33 files  ±0  109 suites  ±0   56s ⏱️ ±0s
611 tests ±0  598 ✔️ ±0  13 💤 ±0  0 ±0 
627 runs  ±0  607 ✔️ ±0  20 💤 ±0  0 ±0 

Results for commit 96a2eb2. ± Comparison against base commit d4920e3.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4920e3) 65.19% compared to head (96a2eb2) 65.19%.

Additional details and impacted files
@@              Coverage Diff              @@
##           v8.0-preview     #619   +/-   ##
=============================================
  Coverage         65.19%   65.19%           
=============================================
  Files               211      211           
  Lines              4864     4864           
  Branches            303      303           
=============================================
  Hits               3171     3171           
  Misses             1602     1602           
  Partials             91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojtek2288
Copy link
Contributor Author

Actually this seems to be fixed in 8.0.100 (PR with bump passes). Will wait for merge. dotnet/sdk#36434

@wojtek2288 wojtek2288 closed this Nov 16, 2023
@wojtek2288 wojtek2288 deleted the fix/csharpier-tool branch November 16, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant