-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patrol is built into a release app, even when it is a dev_dependency #681
Comments
(Android) Verify that Patrol's code is built into the app
The same can be done for other dev_dependencies that shouldn't land in the app binary, but they do, e.g.
|
Got the same issue @bartekpacia. Looking forward to a fix, although it is not stopping us as we dropped back to 0.9.1 for now. |
@KonAtPropertyMe I'm working on a fix (or rather a nicer workaround, because the root cause lies in Flutter itself) For the time being, you can update to the newest Patrol (v0.10.5) and use the below script (made by @jarekb123) to remove dependency on # This script is run before fastlane build (mainly iOS build)
#
# It's a workaround for Apple app rejection:
# ITMS-90338: Non-public API usage - The app references non-public selectors in Frameworks/patrol.framework/patrol: terminate.
cp pubspec.yaml pubspec_copy.yaml
sed '/patrol/d' pubspec_copy.yaml > pubspec.yaml
rm pubspec_copy.yaml
flutter pub get |
#727 introduced a workaround for this. Now the |
Still getting this on the latest version
|
Oh, so that means App Store has broadened its definition of "non-public selectors". We need to get this fixed ASAP. cc @jBorkowska @mateuszwojtczak - this prevents apps that import @jeremiahlukus For now, you can remove the |
This should be fixed (again) in v1.0.8. |
This is still a problem. Yes, we do have a workaround implemented, but we'd like to see it fixed upstream :) |
That's what Apple sent us after we released an app using patrol v0.10.2 on Test Flight.
This is the line which is causing this warning.
It also hints at a much bigger problem – Patrol's native code is built into an app binary in release mode, which increases its size. I haven't done any benchmarks, but gRPC which we're using isn't known for being lightweight...
cc @mateuszwojtczak
Related issues:
The text was updated successfully, but these errors were encountered: