Operations for bit representation of Nat and BitVec.
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehendrix
force-pushed
the
bitvec_scan
branch
from
5e1c285
to
e6c22fb
Compare
digama0
reviewed
Nov 15, 2023
digama0
reviewed
Nov 15, 2023
joehendrix
force-pushed
the
bitvec_scan
branch
4 times, most recently
from
8b340c3
to
2fd27f9
Compare
joehendrix
force-pushed
the
bitvec_scan
branch
from
2fd27f9
to
8fe48e0
Compare
joehendrix
changed the title
joehendrix
changed the title
Nat and BitVec.
joehendrix
changed the title
Nat and BitVec.Nat and BitVec.
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
semorrison
reviewed
Nov 23, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
joehendrix
force-pushed
the
bitvec_scan
branch
from
30b8c79
to
d61e9e7
Compare
|
@semorrison I think I've done all the changes you suggested. |
joehendrix
added
will-merge-soon
semorrison
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 29, 2023
eric-wieser
reviewed
Nov 29, 2023
Comment on lines
+288
to
+291
| theorem testBit_bitwise | ||
| (false_false_axiom : f false false = false) (x y i : Nat) | ||
| : (bitwise f x y).testBit i = f (x.testBit i) (y.testBit i) := by | ||
| induction i using Nat.strongInductionOn generalizing x y with |
There was a problem hiding this comment.
This formatting looks pretty weird to me
2 tasks
eric-wieser
reviewed
Nov 29, 2023
Comment on lines
+13
to
+14
| theorem toNat_eq (x y : BitVec n) : x = y ↔ x.toNat = y.toNat := | ||
| Iff.intro (congrArg BitVec.toNat) eq_of_toNat_eq |
There was a problem hiding this comment.
Mathlib has this lemma, but calls it toNat_inj and states it in reverse.
joehendrix
removed
the
will-merge-soon
alexkeizer
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 30, 2023
revert . fix a bit blech one more comment out broken and unused results chore: bump Std remove redundant simp lemmas cleanup fix: make `Nat.testBit_bitwise` a simp-lemma again. This fixes the Int.testbit_bitwise proofs fix `castNum_testBit` fix `testBit_eq_inth` fixes golf golf Apply suggestions from code review Co-authored-by: Eric Wieser <wieser.eric@gmail.com> fix whitespace fix name conflict more efficient restore lemma feat: Mapping extreme points under continuous maps (#8574) Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme points of the image of that set. Also fix a few name and tweak the API a bit. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> chore(Profinite): allow more universe flexibility in Profinite/CofilteredLimit (#8613) We allow the indexing category for the cofiltered limit in the result `Profinite.exists_locallyConstant` to live in a smaller universe than our profinite sets. feat(CategoryTheory): `Preregular` and `FinitaryPreExtensive` implies `Precoherent` (#8643) We prove some results about effective epimorphisms which allow us to deduce that a category which is `FinitaryPreExtensive` and `Preregular` is also `Precoherent`. feat(Analysis/Seminorm): add more `*ball_smul_*ball` (#8724) We had `ball_smul_ball` and `closedBall_smul_closedBall`. Add versions with mixed `ball` and `closedBall`. Also move this lemmas below and golf the proofs. feat: the annihilator of the kernel of the trace form of a Lie module is contained in the span of its weights (#8739) fix breakage in BitVec lemmas
alexkeizer
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 30, 2023
revert . fix a bit blech one more comment out broken and unused results chore: bump Std remove redundant simp lemmas cleanup fix: make `Nat.testBit_bitwise` a simp-lemma again. This fixes the Int.testbit_bitwise proofs fix `castNum_testBit` fix `testBit_eq_inth` fixes golf golf Apply suggestions from code review Co-authored-by: Eric Wieser <wieser.eric@gmail.com> fix whitespace fix name conflict more efficient restore lemma feat: Mapping extreme points under continuous maps (#8574) Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme points of the image of that set. Also fix a few name and tweak the API a bit. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> chore(Profinite): allow more universe flexibility in Profinite/CofilteredLimit (#8613) We allow the indexing category for the cofiltered limit in the result `Profinite.exists_locallyConstant` to live in a smaller universe than our profinite sets. feat(CategoryTheory): `Preregular` and `FinitaryPreExtensive` implies `Precoherent` (#8643) We prove some results about effective epimorphisms which allow us to deduce that a category which is `FinitaryPreExtensive` and `Preregular` is also `Precoherent`. feat(Analysis/Seminorm): add more `*ball_smul_*ball` (#8724) We had `ball_smul_ball` and `closedBall_smul_closedBall`. Add versions with mixed `ball` and `closedBall`. Also move this lemmas below and golf the proofs. feat: the annihilator of the kernel of the trace form of a Lie module is contained in the span of its weights (#8739) fix breakage in BitVec lemmas
eric-wieser
reviewed
Nov 30, 2023
| else | ||
| simp [h] | ||
|
|
||
| theorem toNat_append (x : BitVec m) (y : BitVec n) : (x ++ y).toNat = x.toNat <<< n ||| y.toNat := |
There was a problem hiding this comment.
In mathlib this had arguments msbs and lsbs for clarity; it feels like a regression to rename them back to x and y.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 30, 2023
Notably leanprover-community/batteries#366 changed the definition of `testBit` (to something equivalent) when upstreaming it, which broke a handful of proofs. Other conflicting changes in Std, resolved for now by priming the mathlib name: * `Std.BitVec.adc`: the type was changed from `BitVec (n + 1)` to `Bool × BitVec w` * `Nat.mul_add_mod`: the type was changed from `(a * b + c) % b = c % b` to `(b * a + c) % b = c % b` [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/348111-std4/topic/Mathlib.20bump.20for.20.22Operations.20for.20bit.20representation.20of.20.2E.2E.2E.22/near/404801443) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex Keizer <alex@keizer.dev> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
awueth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 19, 2023
Notably leanprover-community/batteries#366 changed the definition of `testBit` (to something equivalent) when upstreaming it, which broke a handful of proofs. Other conflicting changes in Std, resolved for now by priming the mathlib name: * `Std.BitVec.adc`: the type was changed from `BitVec (n + 1)` to `Bool × BitVec w` * `Nat.mul_add_mod`: the type was changed from `(a * b + c) % b = c % b` to `(b * a + c) % b = c % b` [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/348111-std4/topic/Mathlib.20bump.20for.20.22Operations.20for.20bit.20representation.20of.20.2E.2E.2E.22/near/404801443) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Alex Keizer <alex@keizer.dev> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR that has operations for working with Nat and BitVec as functions from indices to Bool. In particular it builds upon work in #314 and #358