New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Mapping extreme points under continuous maps #8574
Conversation
Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme points of the image of that set. Also fix a few name and tweak the API a bit.
Mathlib/Analysis/Convex/Extreme.lean
Outdated
section OrderedRing | ||
variable [OrderedRing 𝕜] [AddCommGroup E] [Module 𝕜 E] [AddCommGroup F] [Module 𝕜 F] | ||
|
||
lemma image_extremePoints (f : E ≃ₗ[𝕜] F) (s : Set E) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this live in a namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extremePoints
is not in a namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant LinearEquiv.image_extremePoints
. Or use a typeclass assumption on the type of f
(LinearEquivClass
?). BTW, this is true for affine equivalences as well but we don't have AffineEquivClass
yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah sure. My hope was that we will only need one lemma for all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to using LinearEquivClass
. You can see why I originally didn't want to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have functions "from class to hom" for some other homs. I think that we should either add it here, or generalize relevant parts to *Class
. I can have a look in ~1h.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I golfed. I think that we should add a definition SemilinearMapClass.toLinearMap
but this may wait.
bors d+
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
I ended up adding bors merge |
Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme points of the image of that set. Also fix a few name and tweak the API a bit. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Pull request successfully merged into master. Build succeeded: |
revert . fix a bit blech one more comment out broken and unused results chore: bump Std remove redundant simp lemmas cleanup fix: make `Nat.testBit_bitwise` a simp-lemma again. This fixes the Int.testbit_bitwise proofs fix `castNum_testBit` fix `testBit_eq_inth` fixes golf golf Apply suggestions from code review Co-authored-by: Eric Wieser <wieser.eric@gmail.com> fix whitespace fix name conflict more efficient restore lemma feat: Mapping extreme points under continuous maps (#8574) Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme points of the image of that set. Also fix a few name and tweak the API a bit. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> chore(Profinite): allow more universe flexibility in Profinite/CofilteredLimit (#8613) We allow the indexing category for the cofiltered limit in the result `Profinite.exists_locallyConstant` to live in a smaller universe than our profinite sets. feat(CategoryTheory): `Preregular` and `FinitaryPreExtensive` implies `Precoherent` (#8643) We prove some results about effective epimorphisms which allow us to deduce that a category which is `FinitaryPreExtensive` and `Preregular` is also `Precoherent`. feat(Analysis/Seminorm): add more `*ball_smul_*ball` (#8724) We had `ball_smul_ball` and `closedBall_smul_closedBall`. Add versions with mixed `ball` and `closedBall`. Also move this lemmas below and golf the proofs. feat: the annihilator of the kernel of the trace form of a Lie module is contained in the span of its weights (#8739) fix breakage in BitVec lemmas
revert . fix a bit blech one more comment out broken and unused results chore: bump Std remove redundant simp lemmas cleanup fix: make `Nat.testBit_bitwise` a simp-lemma again. This fixes the Int.testbit_bitwise proofs fix `castNum_testBit` fix `testBit_eq_inth` fixes golf golf Apply suggestions from code review Co-authored-by: Eric Wieser <wieser.eric@gmail.com> fix whitespace fix name conflict more efficient restore lemma feat: Mapping extreme points under continuous maps (#8574) Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme points of the image of that set. Also fix a few name and tweak the API a bit. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> chore(Profinite): allow more universe flexibility in Profinite/CofilteredLimit (#8613) We allow the indexing category for the cofiltered limit in the result `Profinite.exists_locallyConstant` to live in a smaller universe than our profinite sets. feat(CategoryTheory): `Preregular` and `FinitaryPreExtensive` implies `Precoherent` (#8643) We prove some results about effective epimorphisms which allow us to deduce that a category which is `FinitaryPreExtensive` and `Preregular` is also `Precoherent`. feat(Analysis/Seminorm): add more `*ball_smul_*ball` (#8724) We had `ball_smul_ball` and `closedBall_smul_closedBall`. Add versions with mixed `ball` and `closedBall`. Also move this lemmas below and golf the proofs. feat: the annihilator of the kernel of the trace form of a Lie module is contained in the span of its weights (#8739) fix breakage in BitVec lemmas
Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme points of the image of that set. Also fix a few name and tweak the API a bit. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Prove that extreme points are preserved under affine equivalences, and the less trivial statement that a continuous affine map sends extreme points of a compact set to a superset of the extreme
points of the image of that set.
Also fix a few name and tweak the API a bit.