Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(init/meta/tactic): by_contradiction tweaks #491

Closed
wants to merge 3 commits into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Oct 27, 2020

This adds support for classical by_contradiction, as well as always using
intro instead of intro1 (which picks up the binder variable of not,
which is never meaningful), instead using h as default name.

This adds support for classical `by_contradiction`, as well as always using
`intro` instead of `intro1` (which picks up the binder variable of `not`,
which is never meaningful), instead using `h` as default name.
@bryangingechen bryangingechen linked an issue Oct 27, 2020 that may be closed by this pull request
1 task
@gebner
Copy link
Member

gebner commented Oct 27, 2020

The by_contradiction test still fails.

@digama0
Copy link
Member Author

digama0 commented Oct 27, 2020

I know how to fix the test but not how to fix the expected out file.

@gebner
Copy link
Member

gebner commented Oct 27, 2020

./test_single.sh .../lean/bin/lean by_contradiction.lean prints a diff.

@gebner
Copy link
Member

gebner commented Oct 27, 2020

bors r+

bors bot pushed a commit that referenced this pull request Oct 27, 2020
This adds support for classical `by_contradiction`, as well as always using
`intro` instead of `intro1` (which picks up the binder variable of `not`,
which is never meaningful), instead using `h` as default name.
@bors
Copy link

bors bot commented Oct 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(init/meta/tactic): by_contradiction tweaks [Merged by Bors] - feat(init/meta/tactic): by_contradiction tweaks Oct 27, 2020
@bors bors bot closed this Oct 27, 2020
@bors bors bot deleted the by_contra branch October 27, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

by_contra should use classical reasoning
2 participants