[Merged by Bors] - chore(library/init/data/nat): backport Nat.le from Lean4 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason for the timeouts seems to be related to strings: set_option profiler true
example (h : 'h' = 'w') : false := by cases h -- before and now 0.4s
example (h : "h" = "w") : false := by cases h -- before 0.5s, now 7s
example (h : ['h'] = ['w']) : false := by cases h -- before 0.4s, now 2.7sFrom what I can tell, this is because Lean tries to unify |
|
would it make sense to make |
|
I'd rather make |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
The corresponding PR to mathlib is leanprover-community/mathlib#8756. Co-authored-by: Gabriel Ebner <gebner@gebner.org>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
semorrison
added a commit
that referenced
this pull request
Aug 21, 2021
bors bot
pushed a commit
that referenced
this pull request
Aug 25, 2021
…' (#607) Daniel and Leo have decided to instead to try forward porting Lean3's `nat.le`, so in the meantime I think we should revert #603 to maintain compatibility with mathlib. :-) https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Nat.2Ele.20backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding PR to mathlib is leanprover-community/mathlib#8756.