feat(*): backport Nat.le from Lean4 #8756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
blocked-by-other-PR
github-actions
bot
removed
the
blocked-by-other-PR
bors bot
pushed a commit
to leanprover-community/lean
that referenced
this pull request
Aug 20, 2021
The corresponding PR to mathlib is leanprover-community/mathlib#8756. Co-authored-by: Gabriel Ebner <gebner@gebner.org>
pechersky
reviewed
Aug 20, 2021
Comment on lines
+356
to
+359
| cases nat.eq_or_lt_of_le m_lt_n with h succ_m_lt_n, | ||
| { -- the difficult case at the squashed position: we first obtain the values from | ||
| -- the sequence | ||
| subst h, |
There was a problem hiding this comment.
Suggested change
| cases nat.eq_or_lt_of_le m_lt_n with h succ_m_lt_n, | |
| { -- the difficult case at the squashed position: we first obtain the values from | |
| -- the sequence | |
| subst h, | |
| rcases m_lt_n.eq_or_lt with rfl|succ_m_lt_n, | |
| { -- the difficult case at the squashed position: we first obtain the values from | |
| -- the sequence |
and similar below
|
Unfortunately when we made |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR to leanprover-community/lean#603, updating mathlib3 to use the definition of Nat.le preferred in Lean4.
It's not always smooth sailing, and in particular it's now more awkward to use
casesorinductionon inequalities innat.If anyone sees a way to do this better, please let me know!
Until we merge the PR to Lean3 itself, this PR won't build, but it does appear to build locally!