Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lean-web-editor #4

Merged

Conversation

bryangingechen
Copy link
Collaborator

@cipher1024 suggested that I PR my version of the lean-web-editor here.

Thanks to @semorrison for kindly agreeing to host the emscripten files and the zip bundle that the web editor relies on!

@semorrison
Copy link
Collaborator

Hi @bryangingechen, could you quickly explain where this will end up deployed?

@bryangingechen
Copy link
Collaborator Author

Sure, I think it should end up at https://leanprover-community.github.io/lean-web-editor

@bryangingechen
Copy link
Collaborator Author

bryangingechen commented Jun 24, 2019

Oh wait, do I need to do something with the jekyll config to get this to work?

edit I guess not. But I realized I forgot to actually link to the web editor from the index page.

@robertylewis
Copy link
Member

Thanks! This looks nice. When I test it locally, Lean runs extremely slowly. (The editor is perfectly responsive, but it takes ages to check a few lines.) Any idea why?

I suppose we can just merge and test it in production.

@robertylewis robertylewis merged commit abec1ce into leanprover-community:master Jun 26, 2019
@robertylewis
Copy link
Member

The production version is much faster. Not sure what the difference is!

@bryangingechen bryangingechen deleted the lean-web-editor branch June 26, 2019 17:54
@bryangingechen
Copy link
Collaborator Author

bryangingechen commented Jun 26, 2019

Strange - I'm getting CORS errors for the file https://tqft.net/lean/web-editor/lean_js_wasm.wasm when I visit https://leanprover-community.github.io/lean-web-editor. Following up with @semorrison on Zulip...

Edit: The issue is with the uBlock rule discussed here. Adding this custom filter @@||*$xmlhttprequest,domain=leanprover-community.github.io solved the problem.

@cipher1024
Copy link
Contributor

Is there a way to make several versions available?

@bryangingechen
Copy link
Collaborator Author

Several versions of community Lean? Yes, but it would take some work. What did you have in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants