-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WASM files by default? (discussion) #2309
Comments
It is blocked by
That means wasm is blocked by default only for the mentioned domains, I do not know why |
because of the coin mininig https://forums.lanik.us/viewtopic.php?p=133703#p133703 |
Okay, so it's not every WASM file, thanks. But wouldn't it be more reasonable to just block the miner scripts specifically and not github.io globally? |
Like I said it is not my decision, |
https://twitter.com/bad_packets/status/957014570085724161 It seems that @github does not care :-/
|
Well, the site mentioned on twitter - |
I still think blocking those |
my thoughts, github arent helping the spread of coin miners using github. the moment we blocked one github address, they'll just cloned many more domains. I'm open to other options, but this method was best way to limit/counter it. |
tl;dr i'm not going to maintain revolving github domain coinminers 24/7. |
What about using |
The bonus here, we eliminate coin miners from sites that aren't known to us. To be honest, I've seen little issues with this (updated) filter. smed79's list of github domains is just small segment of coinmining issue with github. The other option we could tweak the filter to be a little more specific to avoid false positives. |
I did not know that the mining issue is a widespread phenomenon on |
agreed. |
Not sure why this issue report was edited,and my comments removed. Its not a badfilter. Basically this commit will allow coinminer's to sleep easy tonight knowing uBo will allow them to run. |
I did not remove any of your comments, they are still here and the commit still blocks all wasm requests on
|
I just tested it again, unless you are telling me that those two domains are actually used for
means. |
@ryanbr Please 🙏 shutdown 🙊 and leave this discussion 💥. |
The tweet says:
Can't we use that information to make the filter more specific? (example: Blocking all WASM resources on GitHub by default is going to become more and more of an issue. See https://twitter.com/Doomed_Daniel/status/1001521553157378053. Also, the current filter is sub-optimal, an untokenizable regex-based filter. |
easylist updated their filter to not block github wasm in commit easylist/easylist@5e6a19c does anything need to be done on ublock origin to pick it up, or is it automatic? If it is automatic how long does it take? |
I am not sure I understand. the updated filter in
means that this filter will only be applied at the mentioned domains. For |
@okiehsch correct does anything need to be done on ublock origin to pick up the change, or is it automatic? If it is automatic how long does it take? |
If you mean the updated The old |
You can manually update any list by clicking the clock icon next to it and then click "Update Now". |
Lines 981 to 986 in 0390dfb
I can repro the problem by going to https://knicknic.github.io/wasm-imagemagick/index.1.2.3.html that was fixed in easylist/easylist@5e6a19c |
They changed the filter in EasyPrivacy to:
So we need to update the badfilter. |
URL(s) where the issue occurs
https://edwin0cheng.github.io/unrust/demo/sponza/
https://aochagavia.github.io/rocket_wasm/
(disable the uBlock to see the actual games)
Describe the issue
The problem is that UBlock Origin seems to block all .wasm files by default. This is problematic if WASM wants to be a competitor / replacement for JavaScript (as many people would like it to be). Right now UBlock simply blocks all .wasm files, even though many are not malicious or serve ads, but are rather a replacement for JavaScript files, notably for web games and generally speeding up heavy computations on websites.
Not many users want to be told to disable their AdBlocker to run WASM, which is understandable. I think that WASM files should be handled equally to JS files - if they do contain ads, they get put on a list and get blocked. However, blocking all WASM content is IMO a major inconvenience - many people report the website as "not working", while in reality it's just their ad blocker. So in the end, browsers can support WASM, but if the ad blocker blocks them - not many users will disable uBlock, just to make the page work. Therefore WASM won't gain any traction from developers since it gets blocked by default, but the equivalent JavaScript doesn't get blocked, so developers will continue to use JavaScript and deliver slower than necessary pages.
I wanted to ask if the uBlock Team could allow WASM files by default and if not, what the reasons for this decision are. I am not affiliated with any marketing / ad company, just wanted to ask.
Versions
Settings
No changes, default uBlock Origin install:
The text was updated successfully, but these errors were encountered: