Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed measures #8

Merged
merged 16 commits into from Aug 11, 2022
Merged

fixed measures #8

merged 16 commits into from Aug 11, 2022

Conversation

faenuccio
Copy link
Collaborator

No description provided.

@jcommelin
Copy link
Member

This currently has conflicts. Could you please look into those?

@faenuccio
Copy link
Collaborator Author

I think it is OK now. I have two comments though:

  1. Theorems 2.4.14 and 2.2.6 seem two exact copies of one another. Should this be fixed?
  2. In Section 2.2 I was using $\mathbb{Z}(\kern-.2em(T)\kern-.2em)$ (and likewise for square brackets) whereas in 2.4 it is $\mathbb{Z}((T))$ (different spacing between the brackets). Should this be uniformised?

@jcommelin
Copy link
Member

@faenuccio Yes please, and yes please (-;

modified spacing double bracket
modified mathbf to mathbb for Z, N, R, F
@faenuccio
Copy link
Collaborator Author

OK, I have performed all modifications; I have also observed that sometimes we wrote $\mathbb{Z}$ and sometimes $\mathbf{Z}$ (and similarly for the reals and naturals). I have uniformised everything.

src/measures.tex Outdated Show resolved Hide resolved
src/measures.tex Outdated Show resolved Hide resolved
src/measures.tex Outdated Show resolved Hide resolved
src/measures.tex Show resolved Hide resolved
src/measures.tex Outdated Show resolved Hide resolved
src/measures.tex Outdated Show resolved Hide resolved
src/measures.tex Outdated Show resolved Hide resolved
src/measures.tex Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Did you check whether this gives a connected dep-graph with all nodes coloured green? (If not, I can check it.)

faenuccio and others added 4 commits August 9, 2022 23:07
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
@faenuccio
Copy link
Collaborator Author

Did you check whether this gives a connected dep-graph with all nodes coloured green? (If not, I can check it.)

No, I thought it could not be done on non-master branches. Can you check (and can you tell me how to get a graph on non-master branches?)

@jcommelin
Copy link
Member

I get the following errors:

Lean declaration normed_group_hom.surjective_on_with not found
Lean declaration ses.continuous_θ_c not found
Lean declaration condensed.exact_of_exact_with_constant not found
Lean declaration thm69.θ_ϕ_exact not found

@faenuccio
Copy link
Collaborator Author

OK, let me have a look.

@jcommelin jcommelin merged commit 9543785 into master Aug 11, 2022
@faenuccio faenuccio deleted the fae_measures branch August 11, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants