Skip to content

Commit

Permalink
fix(scripts/deploy_docs.sh): header override is already unset
Browse files Browse the repository at this point in the history
Before, the nightly and doc deploys were running in different builds.
Now they're in the same build, so we don't need to (and can't) unset the
variable twice.
  • Loading branch information
robertylewis committed Feb 13, 2020
1 parent 56a5240 commit 0372fb0
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions scripts/deploy_docs.sh
Expand Up @@ -3,11 +3,6 @@ DEPLOY_NIGHTLY_GITHUB_USER=leanprover-community-bot
set -e
set -x

# By default, github actions overrides the credentials used to access any
# github url so that it uses the github-actions[bot] user. We want to access
# github using a different username.
git config --unset http.https://github.com/.extraheader

This comment has been minimized.

Copy link
@gebner

gebner Feb 13, 2020

Member

Hmmm, won't this break now on all builds except for the first one of the day?

This comment has been minimized.

Copy link
@robertylewis

robertylewis Feb 13, 2020

Author Member

Nope. deploy_nightly.sh runs the config line before checking if it needs to deploy anything.

git_hash="$(git log -1 --pretty=format:%h)"
git clone https://github.com/leanprover-community/doc-gen.git
cd doc-gen
Expand Down

0 comments on commit 0372fb0

Please sign in to comment.