Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/direct_sum): specialize submodule_is_internal.independent to add_subgroup #10108

Closed
wants to merge 8 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 2, 2021

This adds the lemmas disjoint.map_order_iso and complete_lattice.independent.map_order_iso (and iff versions), and uses them to transfer some results on submodules to add_submonoids and add_subgroups.


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Nov 2, 2021
@eric-wieser eric-wieser added this to In progress in Graded modules, rings, and algebras via automation Nov 2, 2021
src/order/rel_iso.lean Outdated Show resolved Hide resolved
Copy link
Member Author

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new iff lemma makes things easier

src/linear_algebra/dfinsupp.lean Outdated Show resolved Hide resolved
src/linear_algebra/dfinsupp.lean Outdated Show resolved Hide resolved
src/linear_algebra/dfinsupp.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 8, 2021
@ocfnash
Copy link
Collaborator

ocfnash commented Nov 8, 2021

bors d+

@bors
Copy link

bors bot commented Nov 8, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 8, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 8, 2021
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 8, 2021
bors bot pushed a commit that referenced this pull request Nov 8, 2021
…nt` to add_subgroup (#10108)

This adds the lemmas `disjoint.map_order_iso` and `complete_lattice.independent.map_order_iso` (and `iff` versions), and uses them to transfer some results on `submodule`s to `add_submonoid`s and `add_subgroup`s.
@bors
Copy link

bors bot commented Nov 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/direct_sum): specialize submodule_is_internal.independent to add_subgroup [Merged by Bors] - feat(algebra/direct_sum): specialize submodule_is_internal.independent to add_subgroup Nov 8, 2021
@bors bors bot closed this Nov 8, 2021
Graded modules, rings, and algebras automation moved this from In progress to Done Nov 8, 2021
@bors bors bot deleted the eric-wieser/order_iso.disjoint branch November 8, 2021 16:03
ericrbg pushed a commit that referenced this pull request Nov 9, 2021
…nt` to add_subgroup (#10108)

This adds the lemmas `disjoint.map_order_iso` and `complete_lattice.independent.map_order_iso` (and `iff` versions), and uses them to transfer some results on `submodule`s to `add_submonoid`s and `add_subgroup`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants