feat(ring_theory/graded_ring): basics #10002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…b.com/leanprover-community/mathlib into feat(homogenous-ideal-of-graded-ring)
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…b.com/leanprover-community/mathlib into feat(homogenous-ideal-of-graded-ring)
jjaassoonn
added
the
awaiting-review
github-actions
bot
removed
the
blocked-by-other-PR
|
I am going to split this pr into smaller ones. |
eric-wieser
reviewed
Nov 2, 2021
Comment on lines
+67
to
+68
| lemma graded_ring.trivial_inter (i : ι) : | ||
| disjoint (A i) (Sup {a | ∃ j ≠ i, A j = a}) := |
There was a problem hiding this comment.
This should fall out in a line or two from #10108. If it doesn't, there's a lemma missing from the API of complete_lattice.independent.
eric-wieser
reviewed
Nov 2, 2021
github-actions
bot
added
the
blocked-by-other-PR
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jjaassoonn
removed
RFC
|
Now every sub-pr is <150 lines modulo dependencies. |
github-actions
bot
removed
the
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
|
This pr is now being subsumed by other sub prs. So I will close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is about typeclasse of graded ring
Zulip: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there.20code.20for.20X.3F/topic/graded.20rings
direct_sum.of#10003Definitions of
graded_ringgraded_algebra#10115Definition of
projand its propertiesproj#10121Definition of
homogeneous_elementhomogeneous_element#10118submodule_is_internal.independentto add_subgroup #10108If I copy and pasted correctly, these sub-prs should be everything this pr has.