[Merged by Bors] - refactor(algebra/direct_sum): rework internally-graded objects #10127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added this to In progress
in Graded modules, rings, and algebras
via automation
Closed
1 task
eric-wieser
added
awaiting-review
jjaassoonn
reviewed
Nov 3, 2021
src/algebra/direct_sum/internal.lean
Outdated
|
|
||
| * `direct_sum.add_submonoid_coe_ring_hom` (a `ring_hom` version of `direct_sum.add_submonoid_coe`) | ||
| * `direct_sum.add_subgroup_coe_ring_hom` (a `ring_hom` version of `direct_sum.add_subgroup_coe`) | ||
| * `direct_sum.submodule_coe_ring_hom` (an `alg_hom` version of `direct_sum.submodule_coe`) |
There was a problem hiding this comment.
Suggested change
| * `direct_sum.submodule_coe_ring_hom` (an `alg_hom` version of `direct_sum.submodule_coe`) | |
| * `direct_sum.submodule_coe_alg_hom` (an `alg_hom` version of `direct_sum.submodule_coe`) |
There was a problem hiding this comment.
Whoops, nice catch; don't write docstrings at 2am!
8 tasks
jcommelin
reviewed
Nov 3, 2021
Co-authored-by: Johan Commelin <johan@commelin.net>
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
This is a replacement for the `graded_ring.core` typeclass in #10115, which is called `set_like.graded_monoid` here. The advantage of this approach is that we can use the same typeclass for graded semirings, graded rings, and graded algebras. Largely, this change replaces a bunch of `def`s with `instances`, by bundling up the arguments to those defs to a new typeclass. This seems to make life easier for the few global `gmonoid` instance we already provide for direct sums of submodules, suggesting this API change is a useful one. In principle the new `[set_like.graded_monoid A]` typeclass is useless, as the same effect can be achieved with `[set_like.has_graded_one A] [set_like.has_graded_mul A]`; pragmatically though this is painfully verbose, and probably results in larger term sizes. We can always remove it later if it causes problems. Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ericrbg
pushed a commit
that referenced
this pull request
Nov 9, 2021
This is a replacement for the `graded_ring.core` typeclass in #10115, which is called `set_like.graded_monoid` here. The advantage of this approach is that we can use the same typeclass for graded semirings, graded rings, and graded algebras. Largely, this change replaces a bunch of `def`s with `instances`, by bundling up the arguments to those defs to a new typeclass. This seems to make life easier for the few global `gmonoid` instance we already provide for direct sums of submodules, suggesting this API change is a useful one. In principle the new `[set_like.graded_monoid A]` typeclass is useless, as the same effect can be achieved with `[set_like.has_graded_one A] [set_like.has_graded_mul A]`; pragmatically though this is painfully verbose, and probably results in larger term sizes. We can always remove it later if it causes problems. Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 17, 2023
Deletes a section that was always content-free, as well as a reference to code that was removed in leanprover-community/mathlib#10127.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for the
graded_ring.coretypeclass in #10115, which is calledset_like.graded_monoidhere. The advantage of this approach is that we can use the same typeclass for graded semirings, graded rings, and graded algebras.Largely, this change replaces a bunch of
defs withinstances, by bundling up the arguments to those defs to a new typeclass. This seems to make life easier for the few globalgmonoidinstance we already provide for direct sums of submodules, suggesting this API change is a useful one.In principle the new
[set_like.graded_monoid A]typeclass is useless, as the same effect can be achieved with[set_like.has_graded_one A] [set_like.has_graded_mul A]; pragmatically though this is painfully verbose, and probably results in larger term sizes. We can always remove it later if it causes problems.This does not fully replace #10115: that PR also provides
We still want that class or something similar to it (replacing
graded_ring.corewithset_like.graded_monoid), but I deliberately leave it out of scope for this PR.