feat(algebra): commuting elements #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
May 28, 2019
urkud
reviewed
Jun 4, 2019
urkud
reviewed
Jun 4, 2019
|
Hi, |
jcommelin
reviewed
Jun 10, 2019
|
Where are up to with this PR? (Neil, if you click the "resolve conversation" button as well as (or even instead of) saying "Done", it's easier for later reviewers to see the status. I've gone through and clicked resolve on a bunch.) |
jcommelin
previously requested changes
Jul 9, 2019
robertylewis
added
the
needs-documentation
rwbarton
reviewed
Sep 27, 2019
|
@jcommelin @ChrisHughes24 I reordered theorems to avoid repeating ourselves, and added lemmas like |
jcommelin
reviewed
Oct 1, 2019
There was a problem hiding this comment.
@robertylewis All the defs now have a docstring, as does the binomial theorem. All the other lemmas are trivialities. I don't think we should require all of those to have a docstring as well, do we?
robertylewis
reviewed
Oct 1, 2019
ChrisHughes24
approved these changes
Oct 4, 2019
ChrisHughes24
added
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
* Not sure how this works * Small refactor of geometric sums * Properties of commuting elements * Geometric sums moved to geom_sum.lean * Geometric sums, two commuting variables * Import geom_sum.lean * Cover commuting elements of noncommutative rings * Whitespace * Add file headers * Delete stray file * Sum/prod over range 0, range 1 * Add simp lemmas * Various changes from PR review * Add semigroup case * Changes from PR review * Corrected all_commute to commute.all * Minor changes from PR review * Change line endings back to unix * `@[to_additive]` can't be a `local attribute` * Rename `add_pow_comm` to `add_pow_of_commute` as suggested by @jcommelin * Add a few missing instances * DRY * Notation for `gsmul` should go into `add_group`, not `group` * Prove `gsmul_one` * Reorder `algebra/commute`, add more lemmas * Add docs, rename `geom_sum₂_mul_add_comm` to `commute.geom_sum₂_mul_add`. * Rename, add a docstring * Fix a typo spotted by @ChrisHughes24 * Move common args to `variables` * Rename `commute.mul` to `commute.mul_right` etc. * Add some `@[simp]` attributes. * More `@[simp]` * Add some `_iff` versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(a * b) ^ n = a ^ n * b ^ nto this context.a ^ n - b ^ nwhenaandbcommute. (Previously we only had this forb = 1.) Refactor uses of theb = 1case slightly.big_operators.leantogeom_sum.lean, to avoid issues with order of imports.Note: a few days ago I submitted a PR dealing with various properties of elements in commutative rings. It was suggested that some parts should be generalised to the noncommutative case. I closed that PR because of some git-related problems, but will resubmit it latter in smaller chunks. This PR is intended to support the requested generalisation.