Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/sign): Allocating signs #14335

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(data/sign): Allocating signs #14335

wants to merge 6 commits into from

Conversation

YaelDillies
Copy link
Collaborator

A sum of integers of absolute value less than n can be broken up as a sum of less than n signs.

From LTE

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label May 23, 2022
eric-wieser
eric-wieser reviewed May 23, 2022
View reviewed changes
src/data/sign.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed May 23, 2022
View reviewed changes
src/data/sign.lean Outdated Show resolved Hide resolved
fpvandoorn
fpvandoorn reviewed Jun 1, 2022
View reviewed changes
src/data/sign.lean Show resolved Hide resolved
src/data/sign.lean Show resolved Hide resolved
@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 1, 2022
@YaelDillies YaelDillies mentioned this pull request Jul 20, 2022
Closed
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-combinatorics Combinatorics and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 31, 2022
@YaelDillies
Copy link
Collaborator Author

YaelDillies commented Aug 31, 2022 •
edited

I have had a look through the application in LTE and am now convinced that

  • I can get rid of the fin restriction
  • It is desirable regardless of this specific lemma.

Hence I switched to the version Floris proposed.

jcommelin
jcommelin reviewed Aug 31, 2022
View reviewed changes
src/data/sign.lean Outdated Show resolved Hide resolved
src/data/sign.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Aug 31, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 31, 2022
@YaelDillies
Copy link
Collaborator Author

Pray for the power of the glue 🙏

bors merge

bors bot pushed a commit that referenced this pull request Aug 31, 2022
@YaelDillies
feat(data/sign): Allocating signs (#14335)
616e6ef 
A sum of integers of absolute value less than `n` can be broken up as a sum of less than `n` signs.
@bors
Copy link

bors bot commented Sep 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/sign): Allocating signs [Merged by Bors] - feat(data/sign): Allocating signs Sep 1, 2022
@bors bors bot closed this Sep 1, 2022
@bors bors bot deleted the exists_signed_sum branch September 1, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. t-combinatorics Combinatorics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @jcommelin @eric-wieser @fpvandoorn