Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(logic/nonempty): pi.nonempty instance #15574

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(logic/nonempty): pi.nonempty instance #15574

wants to merge 3 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jul 20, 2022

Moved from lean-liquid.

Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jul 20, 2022
jcommelin
jcommelin approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jul 20, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 20, 2022
@vihdzp vihdzp added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 20, 2022
@alreadydone
Copy link
Collaborator

I wonder if this should be localized to classical, so it's only available after open_locale classical. I looked it up and it seems the syntax is localized "attribute [instance] pi.nonempty" in classical.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Jul 20, 2022

This is Prop-valued, so I don't think this should matter, unless people are paying really close attention to which axioms the theorems in mathlib use (they aren't).

@YaelDillies
Copy link
Collaborator

This is already in #14335.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Jul 20, 2022

That other PR seems to be biding its time, can't we PR this on its own first?

@YaelDillies
Copy link
Collaborator

Then copy over the changes from there, because thought has already been put into them.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Jul 21, 2022

The lemma as written in #14335 is a clear improvement. I've copied it over.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 21, 2022
@eric-wieser
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jul 21, 2022
@vihdzp
feat(logic/nonempty): pi.nonempty instance (#15574)
6b5a173 
Moved from lean-liquid.
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 21, 2022
@bors
Copy link

bors bot commented Jul 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(logic/nonempty): pi.nonempty instance [Merged by Bors] - feat(logic/nonempty): pi.nonempty instance Jul 21, 2022
@bors bors bot closed this Jul 21, 2022
@bors bors bot deleted the pi_nonempty branch July 21, 2022 12:26
joelriou pushed a commit that referenced this pull request Jul 23, 2022
@vihdzp @joelriou
feat(logic/nonempty): pi.nonempty instance (#15574)
cff31e5 
Moved from lean-liquid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vihdzp @alreadydone @YaelDillies @eric-wieser @jcommelin @leanprover-community-bot-assistant