Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(*): use priority 10 for low priority #1485

Merged
merged 2 commits into from Sep 25, 2019
Merged

cleanup(*): use priority 10 for low priority #1485

merged 2 commits into from Sep 25, 2019

Conversation

fpvandoorn
Copy link
Member

Now we can locally use priorities lower than this low-priority.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

Now we can locally use priorities lower than this low-priority
@fpvandoorn fpvandoorn requested a review from a team as a code owner September 24, 2019 17:36
@fpvandoorn fpvandoorn changed the title refactor(*): use priority 10 for low priority cleanup(*): use priority 10 for low priority Sep 24, 2019
@fpvandoorn fpvandoorn added the awaiting-review The author would like community review of the PR label Sep 24, 2019
@jcommelin
Copy link
Member

Should this PR also open_locale classical wherever it makes sense? Or maybe that's better done in a separate PR?

@fpvandoorn
Copy link
Member Author

That was done already in almost all of the cases in #1319.

Most places which still have local attribute manually is because they don't import tactic/localized, or they change the priority of another declaration at the same time.

Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and straightforward!

@semorrison semorrison added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 25, 2019
@mergify mergify bot merged commit 491a68e into master Sep 25, 2019
@mergify mergify bot deleted the priority branch September 25, 2019 01:31
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
Now we can locally use priorities lower than this low-priority
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants