-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(topology): mild reorganization #1541
Conversation
Another attempt to increase cohesion of modules in topology. The old `constructions` module was starting to turn into a collection of miscellaneous results, and didn't actually contain any constructions themselves. The major changes are: * `constructions` now contains the definitions of the product, subspace, ... topologies, which used to be in `order`. This means that theorems involving concepts from `maps` (e.g., embeddings) and constructions (e.g., products) are now in `constructions`, not `maps`. * `subset_properties` and `separation` now import `constructions` rather than the other way around. This means that theorems like "a product of compact spaces is compact" are now in `subset_properties`, not `constructions`. * `homeomorph` is split off into its own file, which was easy because it was at the end of `constructions` anyways.
In order to make this PR easier to review, I tended to err on the side of minimizing changes, even when it left some individual modules with slightly odd orderings of theorems or |
Marking this WIP until I've finished checking that I haven't inadvertently broken anything. |
After arranging for
|
* refactor(topology): mild reorganization Another attempt to increase cohesion of modules in topology. The old `constructions` module was starting to turn into a collection of miscellaneous results, and didn't actually contain any constructions themselves. The major changes are: * `constructions` now contains the definitions of the product, subspace, ... topologies, which used to be in `order`. This means that theorems involving concepts from `maps` (e.g., embeddings) and constructions (e.g., products) are now in `constructions`, not `maps`. * `subset_properties` and `separation` now import `constructions` rather than the other way around. This means that theorems like "a product of compact spaces is compact" are now in `subset_properties`, not `constructions`. * `homeomorph` is split off into its own file, which was easy because it was at the end of `constructions` anyways. * reorder universes in constructions * move README.md to docs/theories/topology.md * expand documentation of metric/uniform spaces slightly * update pointers to docs/theories/topological_spaces.md
Another attempt to increase cohesion of modules in topology.
The old
constructions
module was starting to turn into a collectionof miscellaneous results, and didn't actually contain any constructions
themselves.
The major changes are:
constructions
now contains the definitions of the product, subspace,... topologies, which used to be in
order
. This means that theoremsinvolving concepts from
maps
(e.g., embeddings) and constructions(e.g., products) are now in
constructions
, notmaps
.subset_properties
andseparation
now importconstructions
rather than the other way around. This means that theorems like
"a product of compact spaces is compact" are now in
subset_properties
,not
constructions
.homeomorph
is split off into its own file, which was easy becauseit was at the end of
constructions
anyways.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list