Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(topology): mild reorganization #1541

Merged
merged 6 commits into from
Oct 12, 2019
Merged

Conversation

rwbarton
Copy link
Collaborator

Another attempt to increase cohesion of modules in topology.
The old constructions module was starting to turn into a collection
of miscellaneous results, and didn't actually contain any constructions
themselves.

The major changes are:

  • constructions now contains the definitions of the product, subspace,
    ... topologies, which used to be in order. This means that theorems
    involving concepts from maps (e.g., embeddings) and constructions
    (e.g., products) are now in constructions, not maps.

  • subset_properties and separation now import constructions
    rather than the other way around. This means that theorems like
    "a product of compact spaces is compact" are now in subset_properties,
    not constructions.

  • homeomorph is split off into its own file, which was easy because
    it was at the end of constructions anyways.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

Another attempt to increase cohesion of modules in topology.
The old `constructions` module was starting to turn into a collection
of miscellaneous results, and didn't actually contain any constructions
themselves.

The major changes are:

* `constructions` now contains the definitions of the product, subspace,
  ... topologies, which used to be in `order`. This means that theorems
  involving concepts from `maps` (e.g., embeddings) and constructions
  (e.g., products) are now in `constructions`, not `maps`.

* `subset_properties` and `separation` now import `constructions`
  rather than the other way around. This means that theorems like
  "a product of compact spaces is compact" are now in `subset_properties`,
  not `constructions`.

* `homeomorph` is split off into its own file, which was easy because
  it was at the end of `constructions` anyways.
@rwbarton
Copy link
Collaborator Author

In order to make this PR easier to review, I tended to err on the side of minimizing changes, even when it left some individual modules with slightly odd orderings of theorems or variables setups. Those can be fixed in independent PRs after this one.

@rwbarton rwbarton added the WIP Work in progress label Oct 12, 2019
@rwbarton
Copy link
Collaborator Author

Marking this WIP until I've finished checking that I haven't inadvertently broken anything.

@rwbarton
Copy link
Collaborator Author

After arranging for Pi.topological_space and sigma.topological_space to take their universe arguments in the same order as before, there are just some boring changes, namely:

  • I removed a redundant argument from is_open_prod_iff' on purpose.
  • I made an argument of the instance normal_space.regular_space explicit for convenience.
  • The instances in topology.bases moved into namespace topological_space, so their names changed.
  • compact_range, dense_embedding.subtype, and the second_countable_topology instance had some implicit/typeclass arguments reordered.

@rwbarton rwbarton removed the WIP Work in progress label Oct 12, 2019
@PatrickMassot PatrickMassot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 12, 2019
@mergify mergify bot merged commit 646c035 into master Oct 12, 2019
@mergify mergify bot deleted the rwbarton-top-refactor branch October 12, 2019 20:08
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
* refactor(topology): mild reorganization

Another attempt to increase cohesion of modules in topology.
The old `constructions` module was starting to turn into a collection
of miscellaneous results, and didn't actually contain any constructions
themselves.

The major changes are:

* `constructions` now contains the definitions of the product, subspace,
  ... topologies, which used to be in `order`. This means that theorems
  involving concepts from `maps` (e.g., embeddings) and constructions
  (e.g., products) are now in `constructions`, not `maps`.

* `subset_properties` and `separation` now import `constructions`
  rather than the other way around. This means that theorems like
  "a product of compact spaces is compact" are now in `subset_properties`,
  not `constructions`.

* `homeomorph` is split off into its own file, which was easy because
  it was at the end of `constructions` anyways.

* reorder universes in constructions

* move README.md to docs/theories/topology.md

* expand documentation of metric/uniform spaces slightly

* update pointers to docs/theories/topological_spaces.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants